search

OpnTec / ots15-companion

Opentech Event app
Apache License 2.0
1.39k stars 5 forks source link

Upload app at Fdroid store #7

Open mariobehling opened 9 years ago

mariobehling commented 9 years ago

Is the app compatible with the licenses allowed at Fdroid? We might have to take out Google maps. Please check.

mananwason commented 9 years ago

No @mariobehling I don't think It'll be compatible with Fdroid. We can change Maps for OpenStreetMaps or we can can just pass an intent to choose application to open maps. I think the second option gives the user more flexibility as OpenStreetMaps are not that detailed,so, user can choose whatever application they like.

championswimmer commented 9 years ago

A gradle flavour without Google Maps will be accepted. From my experience with prior submissions.

We can make such a flavour. So that our FDroid variant uses the url approach or uses OSM, and our Play Store version has embedded maps. On May 9, 2015 12:45 AM, "Manan Wason" notifications@github.com wrote:

No @mariobehling https://github.com/mariobehling I don't think It'll be compatible with Fdroid. We can change Maps for OpenStreetMaps or we can can just pass an intent to choose application to open maps. I think the second option gives the user more flexibility as OpenStreetMaps are not that detailed,so, user can choose whatever application they like.

— Reply to this email directly or view it on GitHub https://github.com/fossasia/ots15-companion/issues/7#issuecomment-100331598 .

leto commented 9 years ago

I like the "intent" idea that @mananwason mentioned, that seems like it would be intuitive and flexible for our users.

mananwason commented 9 years ago

@mariobehling @leto If everyone agrees, I can implement this on another branch.

mariobehling commented 9 years ago

@mananwason I wonder if the embedded Google map is such an important feature, that we need to maintain two different branches. If it is too complicated, we should find a solution, that is easy for both. Just proceed, if this works for now.

mananwason commented 9 years ago

No @mariobehling That's what I am saying that we should work with intents and let user choose application but It would be best if this is done on another branch, even if it's just some lines of code.

tonghuix commented 9 years ago

I suggest we only maintain openstreetmap version, cause it is may easy for us and avoid some licence issues at F-Droid.

And, "intent" also are good idea!

mariobehling commented 9 years ago

We tried to find a simple version with OpenStreetMap but the library implementation was more complicated.

Before we look into detail here, a bigger priority is to get the images on the sponsor page right.

mananwason commented 9 years ago

@mariobehling I am working on that right now.

leto commented 9 years ago

In general, :+1: to creating new branches for new features and bugfixes. Let's move forward with implementing the simplest strategy to get in the Fdroid store and then make iterative improvements from there.

nautilusx commented 9 years ago

Hi I also agree to change to OpenStreetMap or simpler and better - just a link for the location.

In my opinion it's very important to have an open AND FREE (also google free) version for the OTS app.

Can you also please check the permission. We ONLY need the internet access for the time table. Please kill the rest!