Workflow - Githubissues

Oppskrift / oppskrift_api

0 stars 0 forks source link

Workflow #3

Open Scttpr opened 4 years ago

Scttpr commented 4 years ago

I have no access to branch protection rules. I think it would be great to have a protection on master and develop to avoid pushes on it and force PR from feature/* or fix/* branches.

I set develop as default.

Djyp commented 4 years ago

Sure, what kind of protection ?

And the same would go for https://github.com/Oppskrift/oppskrift_web_app

Scttpr commented 4 years ago

If you are ok with that, just to avoid direct push to master and develop. And if possible (never tried), force master PR to come from develop.

And yup, same workflow for web_app

Djyp commented 3 years ago

I gave you the Owner role on the organization so you can set this kind of thing. Unfortunately, according to Github «Protected branches are available to Pro, Team, and Enterprise users», meaning that we can't do that right now

Djyp commented 3 years ago

Weirdly, this page says otherwise :persevere: I don't know how to fix that

Djyp commented 3 years ago

haaa our repos are private ! I was sure they were public ! Let's change that

Djyp commented 3 years ago

I am not quite sure about those rules but they are set ! Please check and validate them before closing this issue @Scttpr