search

OpsMx / spinnaker-helm

Stable helm chart of Spinnaker
Apache License 2.0
23 stars 43 forks source link

Add support for v1 ingresses #17

Closed darend closed 2 years ago

darend commented 2 years ago

Adding support for the V1 ingress spec

See https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/

darend commented 2 years ago

@Nirmalyasen can you review?

Nirmalyasen commented 2 years ago

LGTM! I do not have merge permissions anymore.

@abhinaybyrisetty Can this be merged?

abhinaybyrisetty commented 2 years ago

@Nirmalyasen, Even I don't have write access anymore. I sent an email to OpsMx team for write access.

@ksrinimba, can you check this?

darend commented 2 years ago

@abhinaybyrisetty any luck tracking down a member with write access?

abhinaybyrisetty commented 2 years ago

@darend I didn't get any response from OpsMx team. @rebalag can you have someone merge this?

nuriel77 commented 2 years ago

@darend looks like you're missing backend: in the Ingress of Deck. In gate its okay you didn't delete it.

darend commented 2 years ago

@nuriel77 thanks, it is fixed in https://github.com/OpsMx/spinnaker-helm/pull/17/commits/ef516dfbe1690e337e8278b0e06a7dbffc77340d

abhinaybyrisetty commented 2 years ago

@darend Got the access to this repo. Merging this change.

darend commented 2 years ago

Thank you @abhinaybyrisetty !

darend commented 2 years ago

@abhinaybyrisetty do you want me to open a new PR to bump the chart version?

abhinaybyrisetty commented 2 years ago

Perhaps, we need to automate this process. Bumping chart version and uploading to the repo part!