Opteo / google-ads-api

Google Ads API client library for Node.js
https://opteo.com
MIT License
270 stars 90 forks source link

Upgrade Google Ads to v14 #464

Closed evil-shrike closed 1 year ago

evil-shrike commented 1 year ago

v14 was released on 2023-06-07 (and v14.1 is coming in July/August 2023) https://developers.google.com/google-ads/api/docs/release-notes#v14

Reposting here same as https://github.com/Opteo/google-ads-node/issues/109 to bring more attention. Thank you.

wcoots commented 1 year ago

Made a start on this, but as ever there are issues compiling the latest protos. Will contact Google

rosslavery commented 1 year ago

Any response from Googs 👀?

chixka000 commented 1 year ago

any update on this?

evil-shrike commented 1 year ago

Hi, is there any news on this?

wcoots commented 1 year ago

@evil-shrike @rosslavery @chixka000 Done now, upgraded to the latest version (14.1.0). Let us know if you have any problems.

rosslavery commented 1 year ago

Thanks so much!

evil-shrike commented 1 year ago

Hi, thanks. But after I upgraded to "google-ads-api@14.1" I started getting the following error:

TypeError: Channel credentials must be a ChannelCredentials object
    at new ChannelImplementation (/Users/xxx/work/gaarf/ads-api-fetcher/js/node_modules/google-ads-node/node_modules/@grpc/grpc-js/build/src/channel.js:28:19)
    at new Client (/Users/xxx/work/gaarf/ads-api-fetcher/js/node_modules/google-ads-node/node_modules/@grpc/grpc-js/build/src/client.js:65:36)
    at new ServiceClientImpl (/Users/xxx/work/gaarf/ads-api-fetcher/js/node_modules/google-ads-node/node_modules/@grpc/grpc-js/build/src/make-client.js:58:5)
    at GrpcClient.createStub (/Users/xxx/work/gaarf/ads-api-fetcher/js/node_modules/google-ads-node/node_modules/google-gax/build/src/grpc.js:334:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

as soon as I downgraded to v13 it worked as before.

yakuptekin commented 9 months ago

@evil-shrike Hello, did you solve the problem? If you solved it, can you tell me about it?

evil-shrike commented 9 months ago

Hi @yakuptekin, yes, as far as I remember the issue was caused by different versions of google-gax, so I rebuilt package-lock.json and it helped