Opteo / google-ads-api

Google Ads API client library for Node.js
https://opteo.com
MIT License
270 stars 90 forks source link

"The client has already been closed" Error thrown #468

Open Tasnaditomy22 opened 1 year ago

Tasnaditomy22 commented 1 year ago

Hello,

When using the customer.query method sometimes we get a "The client has already been closed" error thrown after 10 minutes from running the query.

The same usage of cutomer.query with the same query from the same client gives a response in ~1 second, when ran in the time range of +- 1 hour from the one that throws the error. Example query, if it helps: `SELECT campaign.id, customer.id, segments.conversion_action, metrics.conversions, metrics.all_conversions_value, segments.hour, segments.date FROM campaign WHERE segments.date BETWEEN "2023-08-07" AND "2023-08-08"

We've observed this after upgrading to version 13. Do you have an idea if this can be cause by the library or it's just an issue on Google's side ?

cl-vladislavl commented 1 year ago

Same behavior, the issue reproduced for different requests to google ads.

It seems that might be related to this issue since it's coming from gax-nodejs lib, but I didn't manage to find an actual fix.

cl-vladislavl commented 11 months ago

This PR release might fix issue