search

Opteo / google-ads-api

Google Ads API client library for Node.js
https://opteo.com
MIT License
264 stars 88 forks source link

Upgrade Google Ads API to v15 #480

Closed evil-shrike closed 3 months ago

evil-shrike commented 10 months ago

Hello. v15 has been released on the 18th of Oct - https://developers.google.com/google-ads/api/docs/release-notes#v15 Please upgrade the proxy protobufs for v15.

lushu commented 10 months ago

Also there is a blog about the changes in data uploading: Updates to Customer Match, Conversions, and Store Sales Uploads

The Google Ads API v15 release introduced the Consent object for uploading consent with your data. This Consent is used across all uploads for call conversions, click conversions , Customer Match, and Store Sales.

evil-shrike commented 9 months ago

kindly ping

evil-shrike commented 9 months ago

Hi, sorry for bothering I understand it's Christmas period but it's more than 2 month since the API release, could you share any estimates for a v15 support release please?

leovujanic commented 7 months ago

Hi! I'm also interested in this update, especially as they stated in the email "You must complete this update before March 2024 in order to continue using Customer Match for users in EEA."

So any update on the status would be appreciated.

aliqaryan commented 7 months ago

I haven't seen any new commit in this repo for a couple of months now!! is this library still active?

wenson commented 7 months ago

mark it

olchyk98 commented 7 months ago

ping

sheyDev commented 7 months ago

How do we do this ourselves? Is updating the protobufs hard? We really need this upgrade because pulling reporting for asset groups on PMX campaigns are not available till v15.

nghexuanchien commented 7 months ago

Looking forward to v15 update :)

marcolucio commented 7 months ago

we need v15 upgrade too, pls :+1:

evil-shrike commented 7 months ago

Hi. In two weeks (on March 6, 2024 ) the requirement for providing consent for uploading user ids becoming mandatory and it's not supported by the current version (v14), so all user code that depends on this will start failing. Any update on this?

imosing commented 6 months ago

Hi! It's more than 3 months since the latest update already. v16 is released - https://developers.google.com/google-ads/api/docs/release-notes#v16

Can you please share any updates?

marcolucio commented 6 months ago

Just for info I saw there is an open pull request for V15 on the google-ads-node library (https://github.com/Opteo/google-ads-node/pull/118), did someone checked it? We need the update librar before march 15th so we need to know if someone is working actively on it or not, thank you.

danielglh commented 6 months ago

The good news is this package has been upgraded to v16 already...

aliqaryan commented 6 months ago

The good news is this package has been upgraded to v16 already...

Which package?

danielglh commented 6 months ago

The good news is this package has been upgraded to v16 already...

Which package?

This npm package google-ads-node. It has been upgraded to v16 directly and skipped v15.

https://www.npmjs.com/package/google-ads-api

nghexuanchien commented 6 months ago

I tried with v16 and getting the error when creating an offline user data job

Channel credentials must be a ChannelCredentials object at new ChannelImplementation (/usr/src/app/node_modules/google-ads-node/node_modules/@grpc/grpc-js/build/src/channel.js:28:19) at new Client (/usr/src/app/node_modules/google-ads-node/node_modules/@grpc/grpc-js/build/src/client.js:65:36) at new ServiceClientImpl (/usr/src/app/node_modules/google-ads-node/node_modules/@grpc/grpc-js/build/src/make-client.js:58:5) at GrpcClient.createStub (/usr/src/app/node_modules/google-ads-node/node_modules/google-gax/build/src/grpc.js:344:22)

Not sure anyone is also getting the same issue. I'm a little bit unsure what's wrong? Here is my code for the call this.gAdsClient = new GoogleAdsApi({ client_id: <client_id>, client_secret: <client_secret>, developer_token: <developer_token> });

this.customerClient = this.gAdsClient.Customer({ customer_id: <customer_id>, refresh_token: <refresh_token>, login_customer_id: <login_customer_id> });

let jobResponse = await this.customerClient.offlineUserDataJobs.createOfflineUserDataJob({ customer_id: <customer_id>, job: { type: 4, customer_match_user_list_metadata: <customerMatchUserListMetadata> } });

Would hear your thoughts on this ? Thanks

nghexuanchien commented 6 months ago

I resolved above issue by upgrading version for other libraries to make sure the dependency google-gax is consistently at recent newest versions ("^4.3.1")

danielvoelk commented 3 months ago

Google Ads API version 14 is deprecated and will stop accepting requests from June 5, 2024 onwards.

Would be good if version 16 would come out of beta, because in 2 weeks the old version won't work anymore.