search

OptiPie / tradingview-optimizer-extension

OptiPie is an open source strategy optimizer automation tool for TradingView written in js.
https://optipie.app
GNU General Public License v3.0
40 stars 22 forks source link

reportdetail: Add of export to CSV function, button to save as .csv #16

Closed Daemon0x00000000 closed 1 year ago

Daemon0x00000000 commented 1 year ago

Export feature

I added an export feature to your report details page, so you can store reports you created.

AtakanPehlivanoglu commented 1 year ago

Hi @Daemon0x00000000 ,

First of all, thanks a lot for this great contribution and effort. I will review your PR tomorrow and let you know about it here.

I was also considering this addition since some users may want to analyze their reports in a different way, Great work!

Daemon0x00000000 commented 1 year ago

Hi @Daemon0x00000000 ,

First of all, thanks a lot for this great contribution and effort. I will review your PR tomorrow and let you know about it here.

I was also considering this addition since some users may want to analyze their reports in a different way, Great work!

You're welcome! I saw your extension on the chrome webstore and thought it would be cool to pull reports for further investigation.

AtakanPehlivanoglu commented 1 year ago

hey @Daemon0x00000000 ,

I have refactored your branch a little bit(place button inside HTML, update some func names for more readability etc.) and tested it locally without a problem. Could you please check it out so we can align on the latest version of the branch, then I will merge this to the main and will deploy the new version v1.0.3

Daemon0x00000000 commented 1 year ago

@AtakanPehlivanoglu I checked it out, and I like the new user interface. I have also tested it locally and it works perfectly. We could improve the naming of the reports, but everything is good on my end. You can merge it and deploy it.

Daemon0x00000000 commented 1 year ago

I fixed the bug, just edited querySelector.

AtakanPehlivanoglu commented 1 year ago

thanks for the effort @Daemon0x00000000 , but this bug was already resolved in a different issue link Reason I put it in this PR is to merge and deploy them all together at the same time.