search

Optiboot / optiboot

Small and Fast Bootloader for Arduino and other Atmel AVR chips
Other
1.09k stars 401 forks source link

Compilation of some targets fails #258

Closed majekw closed 5 years ago

majekw commented 5 years ago

Curretntly there is a problem with compilation of:

  1. attiny828at8_5v (see https://travis-ci.com/majekw/optiboot/jobs/150388243)
  2. attiny84 (see https://travis-ci.com/majekw/optiboot/jobs/150388244)
  3. luminet (see https://travis-ci.com/majekw/optiboot/jobs/150388273)

I also found:

  1. atmega168 BIGBOOT=1

I remember that attiny84/luminet compiled just fine not so long ago, so this is clearly regression.

majekw commented 5 years ago
  1. and 4. are fixed in #259
majekw commented 5 years ago

attiny84 and luminet targets are broken since eea6dad0aef56aea4687f680eb3c8773ec8ec650

According to https://gcc.gnu.org/onlinedocs/cpp/Defined.html#Defined #if UART == 0 (in https://github.com/Optiboot/optiboot/blob/master/optiboot/bootloaders/optiboot/pin_defs.h#L45) is also true if UART is undefined (as in every SOFT_UART target). It didn't matter before that commit as there wasn't else with error, so this section only did some unnecessary defines. This commit also broke only attiny84 as it's the only target without hardware uart.

majekw commented 5 years ago

attiny84 and luminet also fixed in #259

WestfW commented 5 years ago

Oh no! Pull Requests count as "issues"! I really wanted to "celebrate" issue number 256, since after all Optiboot has a "limit" of 256 instructions - one issue for each machine-level instruction. But #256 sneaked by as a PR without me noticing :-(