Opticos / GWSL-Source

The actual code for GWSL. And some prebuilt releases.
https://opticos.github.io/gwsl/
Other
1.16k stars 80 forks source link

Dashboard Empty When HDR Enabled. #60

Open JerrettDavis opened 3 years ago

JerrettDavis commented 3 years ago

On a fresh install with Windows 10 Pro Build 21364.co_release.210416-1504, opening the dashboard only renders the backdrop. It appears the buttons are present and clickable, but there's no text or images rendered on the backdrop. Even more interesting, when attempting to take a screenshot, the text IS visible!

image

Pololot64 commented 3 years ago

I think you have hdr enabled. The way to go around this is to right click the gwsl icon, click Configure GWSL, and change acrylic_enabled to false instead of true. Then save. This is less pretty but I could not find another workaround

JerrettDavis commented 3 years ago

I think you have hdr enabled. The way to go around this is to right click the gwsl icon, click Configure GWSL, and change acrylic_enabled to false instead of true. Then save. This is less pretty but I could not find another workaround

Looks like that solves the problem. Shame I lose out on the acrylic though. Thanks.

Pololot64 commented 3 years ago

:( Maybe I can change it to a picture or color other than black in the next update

JerrettDavis commented 3 years ago

It's not a major issue, but maybe you can default to acrylic being off for new installations, with an Enable Acrylic option somewhere in the install wizard, or in the dashboard itself. That said, this is the first app, I've encountered rendering issues from with HDR enabled, I'm curious if it's coming from the underlying libraries, or if there's something more funky going on.

Pololot64 commented 3 years ago

Part of it has to do with the fact that GWSL is written in python so I had to get real hacky about supporting acrylic. I don't want it to be disabled by default but maybe I can find a way to detect if hdr is on. I have not found it in the registry yet though

JerrettDavis commented 3 years ago

I'm sure it's not entirely ubiquitous, but it seems Computer\HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\VideoSettings\EnableHDRForPlayback is a good starting point to detect HDR.

Pololot64 commented 3 years ago

Maybe. I need to find an hdr display to test.. The other variables that exist for the same thing perplex me though. The registry is amazingly inconsistent between machines.

JerrettDavis commented 3 years ago

Well, I happen to have several HDR displays to test with, so if you have any experimental builds, please send them my way, and I'd be happy to give them a go.

Pololot64 commented 3 years ago

I can do that. Now I have to mess with the registry to find the real variable if it exists (because the one you mentioned is set to 1 on my pc and I don't have the problem)

Pololot64 commented 3 years ago

And I can do a pretty good "fake acrylic" with the background image image

JerrettDavis commented 3 years ago

I noticed you're down in Dallas, I'm just north of you in Tulsa, OK. If you'd send me an email or a DM me on twitter at @JDDavisPro, I'm happy to give you an HDR display to test with.

As for the registry key, it's a bit misleading. Even if it's set to 1 on your local machine, it won't enable HDR unless windows detects an HDR compatible display. Disabling HDR on my displays (with the registry key set to 1) corrects the issue entirely, but obviously that's not optimal.

Pololot64 commented 3 years ago

Yeah. And thanks that is very thoughtful but I know someone I can borrow one from. ;)

JerrettDavis commented 3 years ago

Sounds good. Feel free to close the issue (or tag it for future reference). I'm able to use the app with acrylic disabled, and that's what matters most.

Pololot64 commented 3 years ago

šŸ‘I will keep it open for a bit though so it can benefit others. I will follow up in a few days or so if I find a fix or have a better build

ReidWeb commented 6 months ago

This issue appears to be presenting itself in the shortcut creator too?

wmsphd commented 4 months ago

i've had this problem on one of my PCs since i first installed gwsl months/years ago and want to try again to find a solution. as in the original post, the dashboard is blank, but shows up in screenshots. I have disabled hdr to no avail. if i set acrylic_enabled to false, or make ANY change in the config i get no dashboard at all, just a taskbar icon. i use bitdefender firewall, malwarebytes and have both start11 and explorerpatcher installed. i have tried disabling both security packages but it didn't help. Win11 23h2 all updates on an asus rog flow z13 used in portrait mode with no keyboard [i.e. as a tablet]. Any help will be appreciated!

Pololot64 commented 4 months ago

I'm gonna try to release an update for this before the end of the summer.

Edit: wait you still have the issue with HDR disabled? So the dashboard still pops up but is blank, it isn't crashing? Does your machine have any special custom graphics or gaming software?

Pololot64 commented 4 months ago

@wmsphd Do you mind right clicking the icon, resetting the settings to default and changing the acrylic enabled flag to false again? It seems like your settings could be corrupted.

wmsphd commented 4 months ago

Hi ā€“

Thanks. I did that several times. I reset the settings and started the app and got a blank dashboard. Then I went into the config and turned off acrylic, started the app, and got nothing but an icon in the taskbar ā€“ no dashboard at all.

I also uninstalled and reinstalled several times.

Iā€™d like to do a completely clean installation, but Iā€™m not sure how to remove everything..

Is there a non-store version? Apps from the store keep way too much inaccessible, making troubleshooting a problem.

I appreciate the quick reply ā€“ and I really like the app on my other PC.

Thanks!!

From: Pololot64 @.> Sent: Friday, July 26, 2024 9:48 AM To: Opticos/GWSL-Source @.> Cc: wmsphd @.>; Mention @.> Subject: Re: [Opticos/GWSL-Source] Dashboard Empty When HDR Enabled. (#60)

@wmsphd https://github.com/wmsphd Do you mind right clicking the icon, resetting the settings to default and changing the acrylic enabled flag to false again? It seems like your settings could be corrupted.

ā€” Reply to this email directly, https://github.com/Opticos/GWSL-Source/issues/60#issuecomment-2252928282 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/AXPBFHPDR5YODB7SY4XBYPLZOJOSFAVCNFSM43QQ3NO2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMRVGI4TEOBSHAZA unsubscribe. You are receiving this because you were mentioned. https://github.com/notifications/beacon/AXPBFHOUSZUPAKHMSL3UC2LZOJOSFA5CNFSM43QQ3NO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOQZEPKGQ.gif Message ID: < @.> @.>

Pololot64 commented 4 months ago

Hmm, Can you please make sure that the settings file has no personal info and then share it here? @wmsphd