search

OptimalBPM / angular-schema-form-dynamic-select

AngularStrap and AngularUI dynamic select implementation(static/sync/async/http, filters) for Angular Schema Form
MIT License
55 stars 45 forks source link

"Map" option feature does not work for strapselect with synchronous callback #38

Closed ngabello closed 9 years ago

ngabello commented 9 years ago

finalOptions is not defined so I am requesting a change to populateTitleMap FROM:

else if (form.options.callback) {
            form.titleMap = $scope.getCallback(form.options.callback)(form.options, search);
            $scope.finalizeTitleMap(form,form.titleMap, finalOptions)
            console.log("callback items: ", form.titleMap);
        }

TO:

else if (form.options.callback) {
            form.titleMap = $scope.getCallback(form.options.callback)(form.options, search);
            $scope.finalizeTitleMap(form,form.titleMap, form.options);
            console.log("callback items: ", form.titleMap);
        }
nicklasb commented 9 years ago

Good catch! Actually a little bit strange that my IDE didn't warn about that one.

nicklasb commented 9 years ago

Fixed in v0.11.7.