OptimalBPM / angular-schema-form-dynamic-select

AngularStrap and AngularUI dynamic select implementation(static/sync/async/http, filters) for Angular Schema Form
MIT License
55 stars 45 forks source link

Wp/osp 3491/7 #85

Closed kksevta closed 8 years ago

nicklasb commented 8 years ago

Well first thanks for your involvement!

However, first some critiques:

  1. This was a huge and wide PR, and that is really not how PRs works, as it makes it basically impossible for the maintainer to see what is being added. A PR adds one distinct functionality, or one distinct fix.
  2. There is no description, I don't know what this is about.
  3. It has conflicts, so it has to be rebased.
  4. I just added a develop branch again, please do any PR:s against that instead.

I know that this is extra work for you, but I am afraid it has to work like this when many people are involved in a project.

In this case I would recommend you to start over with a new fork(rebasing will be a chore anyway), and gradually make PR:s when you add each functionality. It should not be that much work.

And some advice, next time, If you want to make major additions to a project, first contact the maintainer so that you can be sure that no one else is doing what you are doing, and then maintain that contact during development. Usually this is done in an issue where the maintainer and other stakeholders can discuss the solution.

But anyway, thanks again!