Make mongo and redis optional dependencies

OptimalBits / node_acl

Access control lists for node applications

2.62k stars 369 forks source link

Make mongo and redis optional dependencies #238

Open zamiang opened 7 years ago

zamiang commented 7 years ago

closes #221

deksden commented 7 years ago

Good suggestion!

Mongo & Redis are not required when we use 3-d party driver like Knex-based or Sequelize-based (or even we are just developing with in-memory database).

update: shouldn't we need mention proper install steps in readme?

npm install
npm install redis mongo

zamiang commented 7 years ago

@deksden also a good suggestion!

Added a note about installing redis and mongo to the install step of the readme

zamiang commented 7 years ago

@manast any word on this? I believe this is a low risk, simple change but let me know if I can improve it in any dimension.

zamiang commented 6 years ago

@manast any update here?