search

OptimalDesignLab / PDESolver.jl

A Julia-based solver for partial-differential equations.
Other
13 stars 5 forks source link

Warning from SimpleODE tests #74

Open JaredCrean2 opened 7 years ago

JaredCrean2 commented 7 years ago

Running the SimpleODE test suite gives the following output:

INPUT: User did not specify use_Minv but selected run_type is CN. Setting use_Minv = true.
ashleaRPI commented 7 years ago

We talked about this, and I thought you looked at the code and agreed?

It's because we don't yet have infrastructure for the input parser to know what physics module is being called. All Euler and Advection cases running CN must apply the inverse mass matrix, so this message is meant to inform the user that that's what is being done even if they don't specify use_Minv.

SimpleODE does not need the inverse mass matrix, but again there's no way for the input parser to know the user is running SimpleODE. SimpleODE later forces opts["use_Minv"] = false. We viewed it as more critical that the user is warned about a potential CN misuse than a SimpleODE, since SimpleODE is inherently a development/testing physics module.

Also, it's not an actual warning, just a println - this was an attempt to make a level of output about inputs being reset/set within the new input checker that is noticeable but not a full warn() call. I'd be open to suggestions on that of course.

JaredCrean2 commented 7 years ago

I know there isn't anything we can do about this at the moment, but I like to create issues to make sure we don't forget about the problem.