Jcwork3

[JaredCrean2]

Miscellaneous changes. Off the top of my head:

• loosen type signature of something in SymCubatures so we don't Tsbp=Complex128 to operate on complex data
• add macro to disable asserts in the element based routines. Benchmarks showed this is important for performance
• change the trans argument in weakDifferentiateElement from keyword to position. Benchmarking showed this is important

[codecov-io]

Codecov Report

:exclamation: No coverage uploaded for pull request base (work@3510a1f). Click here to learn what that means. The diff coverage is 99.35%.

@@           Coverage Diff           @@
##             work      #19   +/-   ##
=======================================
  Coverage        ?   93.47%           
=======================================
  Files           ?       23           
  Lines           ?     3328           
  Branches        ?        0           
=======================================
  Hits            ?     3111           
  Misses          ?      217           
  Partials        ?        0

Impacted Files	Coverage Δ
src/mappingjacobianrevdiff.jl	0% <ø> (ø)
src/SummationByParts.jl	48.71% <ø> (ø)
src/utils.jl	90.43% <ø> (ø)
src/symcubatures.jl	99.67% <ø> (ø)
src/weakdifferentiate_rev.jl	100% <100%> (ø)
src/directionaldifferentiate.jl	100% <100%> (ø)
src/weakdifferentiate.jl	100% <100%> (ø)
src/faceinterpolate.jl	100% <100%> (ø)
src/volumeintegrate_rev.jl	100% <100%> (ø)
src/differentiate_rev.jl	100% <100%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3510a1f...b91dd4c. Read the comment docs.

[JaredCrean2]

I'm not sure why the Julia 0.5 CI tests time out. The 0.4 ones pass though.

[JaredCrean2]

0.5 CI passes now. Some code was still using sub which was deprecated in 0.5. Unfortunately, deprecation warnings make the code run slow, so the tests appeared as though they stalled.