search

Optiroc / SuperFamiconv

Flexible and composable tile graphics converter supporting Super Nintendo, Game Boy, Game Boy Color, Game Boy Advance, Mega Drive, PC Engine and WonderSwan formats.
MIT License
152 stars 22 forks source link

Error in deciding to use horizontal or vertical flip ends up in using both #13

Closed Molive-0 closed 4 years ago

Molive-0 commented 4 years ago

If an image is being converted which has a tile which is either the horizontal or vertical flip of a previous tile, the previous tile will be used but it will use both vertical and horizontal flipping, meaning it displays as if no flip has occured at all.

For example, consider the following 16 by 8 pixel image:

bonus2

These two tiles could be encoded as the same tile, just with one flipped either horizontally or vertically. Superfamiconv encodes the image as such:

bonus2

The first tile is normal, but the second tile is both flipped horizontally and vertically. This means it looks the same as not flipped at all. In the above case the converter should pick either horizontal or vertical flip but should not pick both.

Optiroc commented 4 years ago

Should be fixed as of 08ef68e211a4978357b42a9903b17cfbe888a78c.

Optiroc commented 4 years ago

@Molive-0 I really liked this bug, btw, good find!