search

Optiroc / SuperFamiconv

Flexible and composable tile graphics converter supporting Super Nintendo, Game Boy, Game Boy Color, Game Boy Advance, Mega Drive, PC Engine and WonderSwan formats.
MIT License
143 stars 20 forks source link

Fix warnings in switches, add install target. #22

Closed lubosz closed 3 years ago

lubosz commented 3 years ago

Cool project!

  1. Switches

I fixed all warnings I encountered in gcc 10.2.0, which were caused by the lack of default cases in Mode.h. While doing this I removed redundant cases that matched the default and merged cases with the same return.

  1. Install target

While packaging superfamiconv in the Arch Linux User Repository I noticed the lack of a CMake install target. This is a one line change that will add a make install target, which can be utilized on platforms that support it.

  1. Redundant Makefile

Not sure if you want to keep it, but since you have a CMake build already I would suggest dropping it.

  1. gitignore

I added some files to gitignore that are generated by CMake when doing an in-tree build.

Optiroc commented 3 years ago

Thanks! Always nice with some hygiene improvements. 👍

I'll probably keep the Makefile since I still prefer using those for small projects like this, and bunch it all up with the usable stuff from an abandoned local feature branch that's been sitting locally for ages.

Optiroc commented 3 years ago

Finally got around to merge these changes. 🤗