Wrong map results when PNG has an index marked as transparent

Optiroc / SuperFamiconv

Flexible and composable tile graphics converter supporting Super Nintendo, Game Boy, Game Boy Color, Game Boy Advance, Mega Drive, PC Engine and WonderSwan formats.

MIT License

152 stars 22 forks source link

Wrong map results when PNG has an index marked as transparent #7

Closed clbr closed 5 years ago

clbr commented 5 years ago

Given a source PNG, 8-bit, where one index is marked as transparent, superfamiconv's map fails to create a correct map. The tiles and palette commands work properly, but the map is missing all tiles that contain that transparent color.

You can create such an image in mtpaint:

open an 8-bit PNG
preferences -> files -> set transparency index to 0
save

clbr commented 5 years ago

Actually, the palette command fails too. It sets the transparent color to black, which is obviously wrong.

Optiroc commented 5 years ago

Some transparency/color_zero issues should be fixed as of https://github.com/Optiroc/SuperFamiconv/commit/7548126b97351454311066a330776113b5ecc37f.

Optiroc commented 5 years ago

I believe these issues should be fixed now. No doubt there are new issues though, since I've refactored the program a lot the last few days. 😉