Optum / dce-cli

Disposable Cloud Environment CLI
Apache License 2.0
38 stars 20 forks source link

Bug/dce deploy still requires gh token #57

Closed joshmarsh closed 4 years ago

joshmarsh commented 4 years ago

Proposed changes

This PR replaces calls to the Github GraphQL API by using the public <repo>/releases/latest/download/<asset> url to download deployment assets.

We were previously using Github's GraphQL API to download assets during dce deployment. This allowed us to authenticate with our private repo using Github Personal Access Tokens. Now that the repo is public, we no longer need or want to use an API that requires auth tokens for downloading assets.

Types of changes

Checklist

Relevant Links

Further comments

eschwartz commented 4 years ago

sweet, thanks @joshmarsh