search

OpusCapita / filemanager

React based FileManager for browser ( + FS REST API for Node.js and Express)
https://demo.core.dev.opuscapita.com/filemanager/master/?currentComponentName=FileManager&maxContainerWidth=100%25&showSidebar=false
Apache License 2.0
566 stars 122 forks source link

auto scroll to selected item with `actions.navigateToDir(folderPath, filePath)` #297

Open c3wenjiaowang opened 3 years ago

c3wenjiaowang commented 3 years ago

When we used navigateToDir with passing both paths for parent folder and the file entry, the navigator would update the current path to the folderPath, and has the according file entry highlighted. But if the folder has a long list of files, and this selected file is down at bottom of the list, the navigator pane is not scrolling to the selected entry, and user has to manually use mouse to scroll down the list. May I ask is there any way we can auto-scroll? Thanks!

visortelle commented 3 years ago

Hi, @c3wenjiaowang. This feature is not implemented.

c3wenjiaowang commented 3 years ago

@visortelle Thanks! I have tried to add the feature in the source code, and it works with that change. May I ask can you add me as a contributor, so that I can submit a PR, and have it added to the library if possible? Thanks a lot!

visortelle commented 3 years ago

@c3wenjiaowang I don't know. I'm not a maintainer of this repo. :)

c3wenjiaowang commented 3 years ago

I created a PR for resolving this issue, but can't add a reviewer on the PR. Could anyone help to review the PR: https://github.com/OpusCapita/filemanager/pull/299? Thanks!