OpusCapita / react-crudeditor

OpusCapita React CRUD Editor
https://opuscapita.github.io/react-crudeditor/branches/master/?currentComponentName=ContractEditor&maxContainerWidth=100%25&showSidebar=false
Apache License 2.0
20 stars 1 forks source link

Save operation is not possible when failed validation of a field from inactive tab #269

Closed amourzenkov-sc closed 6 years ago

amourzenkov-sc commented 6 years ago
Meta-Info Value
ExtProjectId JCPROC-01
Original Estimation 8h
Remaining Estimation 0h

The situation arises when

  1. A new field constraint is added effecting existing server-side DB instances. Loading such an instance for editing does not allow saving changes made in a tab if no-longer-valid field is located in another tab. Error massage is not informative in this case either.

  2. Custom instance-validator compares fields from different tabs and does not allow their consecutive changes (only atomic changes to the fields are allowed).

nstoliar-sc commented 6 years ago

Tested for FF, IE and Chrome. Error message appears correctly and it is possible to expand this message if it has additional information. If user deletes several items and deleting of some item gives error, error message for deleting appropriate item appears while rest items are deleted correctly. Spent 2 hours.

Note: It might be implemented some improvements for usability. Current time of displaying of error message might be too short for reading of message with long text. It is might be better to hold back displaying message, if a user moves mouse cursor over this message, and expand additional information by clicking on it. After moving the mouse out of the message, it could be hidden after brief time.

estambakio-sc commented 6 years ago

Demo for QA

Refer to @amourzenkov-sc or @estambakio-sc for details.

nstoliar-sc commented 6 years ago

Tested for FF, IE, Chrome. If user clicks on message for expanding additional information, message is displayed on time locating of cursor on this message. Please, merge with master branch. Spent 0,5 hours.