search

OpusGang / awsmfunc

awesome VapourSynth functions
MIT License
17 stars 4 forks source link

DynamicTonemap error with tone_mapping_function_s argument in version 1.3.4 #24

Closed patrickenfuego closed 1 year ago

patrickenfuego commented 1 year ago

Hello. I recently started receiving an error with DynamicTonemap after updating the package to 1.3.4 that I was not receiving last week:

vapoursynth.Error: Tonemap: Function does not take argument(s) named tone_mapping_function_s

Not sure if this this is on the awsmfunc site or the vs-placebo side but rolling back to awsmfunc version 1.3.3 seems to fix the issue. I noticed that there have been many changes on the vs-placebo side, but I haven't recompiled the plugin since the last release so maybe that's my problem.

Figured it was worth mentioning. Please let me know if there is anything else I can provide that would be helpful. Thanks for the awesome work.

quietvoid commented 1 year ago

It's only available if you build vs-placebo on https://github.com/Lypheo/vs-placebo/commit/369993de5817defca3e0efa98fd17bdd74e4feaa.

awsmfunc 1.3.3 didn't have tone_mapping_function_s, so it's not possible that you had an old script using it. Though now I guess the argument is always fed to the plugin, hence the error.

patrickenfuego commented 1 year ago

Awesome, thanks for the quick feedback @quietvoid. What do you advise I do on my end, recompile the plugin? Everything is happy at 1.3.3 (tested), but I definitely want to benefit from the latest updates.

quietvoid commented 1 year ago

Yes you need to build the plugin. I might update it and release a new DLL.

patrickenfuego commented 1 year ago

Sounds like a plan, recompiling now. Appreciate your quick response and awesome contributions! Hopefully this will help someone else in the future.