I think we've proven the build hooks idea in the place it is being used.
Before putting it into the main one, we need to test that:
using the docker image directly (i.e. no sub-Dockerfile) still works
using a basic Dockerfile as documented in the updated README.md builds and produces a working Odoo.
The work-in-progress to test and eventually rebase and merge is WIP-10.0-pg10-fix-preinstall-c-compiler, into 10.0-pg10-fix.
We'll need to make the project currently using FROM quay.io/opusvl/odoo-custom:WIP-10.0-pg10-fix-preinstall-c-compiler point back at 10.0-pg10-fix so it's not pointing at a development release forever.
Remember that this will break any existing Odoos based off the 10.0 image, but as explained in the README it will hard-fail to build and it's easy to remedy the derived projects to fix them.
Once done, we should do this to 11.0 as early as possible (raise another bug for that) - while there are few systems based on it it's going to be easier to change them.
I think we've proven the build hooks idea in the place it is being used.
Before putting it into the main one, we need to test that:
The work-in-progress to test and eventually rebase and merge is
WIP-10.0-pg10-fix-preinstall-c-compiler, into10.0-pg10-fix.We'll need to make the project currently using
FROM quay.io/opusvl/odoo-custom:WIP-10.0-pg10-fix-preinstall-c-compilerpoint back at10.0-pg10-fixso it's not pointing at a development release forever.Remember that this will break any existing Odoos based off the 10.0 image, but as explained in the README it will hard-fail to build and it's easy to remedy the derived projects to fix them.
Once done, we should do this to 11.0 as early as possible (raise another bug for that) - while there are few systems based on it it's going to be easier to change them.