search

OraOpenSource / apex-plugin-clob-load

Oracle Application Express (APEX) Plugin for form items with long text content (over 32k)
Other
21 stars 3 forks source link

Uncaught TypeError: Cannot read property 'showSpinner' of undefined #2

Closed tschf closed 7 years ago

tschf commented 7 years ago

I've just installed from https://github.com/OraOpenSource/apex-plugin-clob-load/blob/master/apex-plugin-clob-load.sql, but I seem to be getting the an error with the submit CLOB option, Uncaught TypeError: Cannot read property 'showSpinner' of undefined.

image

image

RogerPilkey commented 7 years ago

In apex-clob-load.js, _handleSubmitClobSuccess takes an argument of opts, but in a couple of places, it's called with no argument. I tried sticking in opts as an argument in all the calls and this error went away, but I don't know if that will break something else. I'm only another user of this plugin.

sthilaire commented 7 years ago

This is good feedback. I have another feedback that I need to get published. It is on my list of things. I will see if I can get a closer look this weekend.

sthilaire commented 7 years ago

The spinner fix should be in place along with some other bugs in the source code checked in. I found another issue that causes caching of previous results that I am trying to get nailed down. When that is done, I will publish the full plugin again.

rimblas commented 7 years ago

Hola Tim! How's the next version coming along? Could you publish the fix you have?

import-time

rimblas commented 7 years ago

Ping

sthilaire commented 7 years ago

Sorry about the delay I was trying to close out some of the issues. My initial test showed this as fixed, but it was an APEX version dependant problem. I am doing cross version testing to see if I can simplify the plugin and not require branched versions. I will let you know what I find.

sthilaire commented 7 years ago

I realized my mistake. The source was updated based on some feedback I received via e-mail, but I did not integrate it into the plugin export.
I have integrated the source changes along with an additional adjustment. It is up for regression testing. Currently only tested in 5.0.0. Testing will continue as time allows.

rimblas commented 7 years ago

Please share the ~love~ code

sthilaire commented 7 years ago

Is the project code not visible to the public? This has not been released yet do to a different bug, but this particular issue is in the current baseline, just not a release.

sthilaire commented 7 years ago

New packaged release 2017.08.04 has been published. This fix along with other minor adjustments have been included.