search

Orama-Interactive / Pixelorama

Unleash your creativity with Pixelorama, a powerful and accessible open-source pixel art multitool. Whether you want to create sprites, tiles, animations, or just express yourself in the language of pixel art, this software will realize your pixel-perfect dreams with a vast toolbox of features. Available on Windows, Linux, macOS and the Web!
https://orama-interactive.itch.io/pixelorama
MIT License
6.83k stars 372 forks source link

Pixelorama Crashes when run from the Godot Editor #960

Closed TheLsbt closed 8 months ago

TheLsbt commented 8 months ago

Pixelorama version:

959

OS/device including version:

Issue is not related to graphics.

Issue description:

When running Pixelorama for source in Godot 4.2 stable an error occurs on lines 690 and 698 in ExtensionsApi.gd. The functions expects 2 arguments however only one is passed. I have found a simple fix for this by passing "ImportApi" (following previous patterns) as the first arguments in these functions. I haven't made a pull request with the changes because I am waiting on @Variable-ind's response as I'm not sure how important those arguments are.

Steps to reproduce: Run the Pixelorama #959 in Godot 4.2 stable

hormigas commented 8 months ago

Looks like they just need to add a name. Changing 690 ExtensionsApi.add_action("ImportAPI", "add_import_option")

and 698 to

ExtensionsApi.remove_action("ImportAPI","add_import_option")

removes the issue. I based the name on the previous name for the exporter.

Variable-ind commented 8 months ago

this fix will be added some time today or tomorrow by @OverloadedOrama :grin: