search

Orange-Cyberdefense / GOAD

game of active directory
GNU General Public License v3.0
4.62k stars 648 forks source link

Full support for vmware_esxi provider #210

Open viris opened 3 months ago

viris commented 3 months ago

Here our team created the necessary files to make the GOAD labs fully compatible with vmware_esxi for easy deployment on VMWare ESXi servers, this includes docs and the goad.sh script changes.

viris commented 2 months ago

this supersedes #203

Mayfly277 commented 2 months ago

really great work ! i have some remarks on the goad.sh scripts modification but no big deal. Also i need to do tests, but i have no esxi to do it :( I have to try to find one x)

rebelinux commented 2 months ago

I can test this!

What's the provider name? vmware_esxi?

viris commented 2 months ago

I can test this!

What's the provider name? vmware_esxi?

Correct

rebelinux commented 2 months ago

I performed tests and everything works fine. The problems that I have experienced are related to the windows image that I had to disable the firewall so that the provisioning with winrm continues but other than that everything seems to run fine. The creation of the VMs on the ESXi server runs smoothly.

Microsoft Active Directory As Built Report.pdf

viris commented 2 months ago

I performed tests and everything works fine. The problems that I have experienced are related to the windows image that I had to disable the firewall so that the provisioning with winrm continues but other than that everything seems to run fine. The creation of the VMs on the ESXi server runs smoothly.

Microsoft Active Directory As Built Report.pdf

Hmm was this related to other image you used or these ones, I didn't have issues. Do you know where the issue lies? in Vagrant or Ansible? also does it affect all labs or specific ones?

rebelinux commented 2 months ago

I performed tests and everything works fine. The problems that I have experienced are related to the windows image that I had to disable the firewall so that the provisioning with winrm continues but other than that everything seems to run fine. The creation of the VMs on the ESXi server runs smoothly. Microsoft Active Directory As Built Report.pdf

Hmm was this related to other image you used or these ones, I didn't have issues. Do you know where the issue lies? in Vagrant or Ansible? also does it affect all labs or specific ones?

I believe is a vagrant issue not related with your code!

https://github.com/Orange-Cyberdefense/GOAD/issues/202

viris commented 2 months ago

@Mayfly277 what else is needed here? should I make the quoting canonical in those cases?

HermessNRJ commented 2 months ago

Hello, Thank you for the work @Mayfly277 @kripskroll (#203) @viris

On my side I made a test from an ubuntu 22.04 to an ESXI 8.0 and I have these errors: image

I solved it by installing the ovf tool with this tuto https://docs.vmware.com/en/VMware-Telco-Cloud-Operations/1.4.0/deployment-guide-140/GUID-95301A42-F6F6-4BA9-B3A0-A86A268754B6.html the download page (pay attention to the vmtool version compared to the esxi version): https://developer.vmware.com/web/tool/4.6.2/ovf-tool/

I think it might be interesting to add it to the documentation.

and speaking of documentation, there's no mention of these parameters in the documentation, wouldn't it be interesting to document them?

viris commented 1 month ago

I guess we need to add a check for ovftool tool as well as it's a requirement for vagrant-vmware-esxi to work, as far as those handy params go will document them.

viris commented 1 month ago

@Mayfly277 I have implemented the changes @HermessNRJ and @rebelinux mentioned, what else is required here? Maybe MINILAB support?

zer0pwned commented 2 days ago

@viris Hi, thanks for your hard work! I just tried your branch over my ESXI instance. I noticed that the ESXI password environment variable seems to be wrong in the Vagrant file. So does Vagrant file in other labs. Maybe you can take another look just in case I missed something?

https://github.com/viris/GOAD/blob/20f13567ebb5e8a14e62c8642a3ae77d101167b5/ad/GOAD/providers/vmware_esxi/Vagrantfile#L50C36-L50C65