search

Orange-Cyberdefense / arsenal

Arsenal is just a quick inventory and launcher for hacking programs
GNU General Public License v3.0
3.19k stars 471 forks source link

Feature/arg uniqueness #93

Open jubeaz opened 5 months ago

jubeaz commented 5 months ago

Hello,

Here is a PR to manage argument uniqueness inside a command.

This is base on the issue that I've opened here https://github.com/Orange-Cyberdefense/arsenal/issues/90

If accepted and merged I'll work on the concept of option [-debug] [-d <domain_fqdn] ...

Not that the logic of value computation has changed.

if inside a command there are <arg|value> the first one will be assigned to all the <arg> inside the command

after I will process the value based on gvars and cheat.variables, so this might again change the value of an arg

Anyway as I explained it in my issue for me having the same <arg> inside a command but wanting to have different value for them is an error

jubeaz commented 5 months ago

Hello,

same problem has in the previous PR 2024-05-25_17-37

v1k1ngfr commented 2 months ago

Hello @jubeaz,

We will keep arsenal as simple as possible with limited options. Maybe your PR can be useful for someone who have same expectations.

Thanks