Closed julien-deramond closed 1 year ago
.has-checkbox
class for tables (v4 and in design specifications).text-muted
? in v5.details
tag ? (https://developer.mozilla.org/fr/docs/Web/HTML/Element/details)details
tag ? (https://developer.mozilla.org/fr/docs/Web/HTML/Element/details)All tasks have a dedicated issue or PR. We can finally close this one.
This issue tracks all the remaining things to backport from Bootstrap v4.
For all actions done from this epic issue:
Don't forget to update the migration page
Ensure to add deprecation warnings in v4 when required (see #560 / #562 for examples).
[x] Gather and sort items from https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/issues/383 then delete it as duplicate
[x] Check the content of https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/640 and define an action_
[x] Compare our v5 components with the design specifications and note the differences
[x] Merge this list with the ones in comments
[x] Study each item and create an issue for each one or delete it
[x] Document somewhere (Discrepancies between Boosted and Bootstrap?)Bootstrap parts dropped in Boosted (and the reasons as an history) and add in the DoDs to update this doc
.floating-label
.form-control-sm
,.form-select-sm
,.input-group-sm
,.col-form-label-sm
-> Should change with #1230.#{$state}-tooltip
table-row-variants()
,.table-bordered
,.table-borderless
,.table-striped
-> Should change with #859.btn-outline
.pagination-sm
nor.pagination-lg
.list-group-item-action
-> Should change with #1467pagination-max-items()
:focus-visible
is still herebackgrounds
color
andbackground-color
utilities have their counter-part to ensure contraststarget-size()
mixin--o-carousel-interval
,.paused
,.done
and.static
data-bs-wrap="false"
$boosted-variable-prefix
to supplement Bootstrap's$variable-prefix
button-icon()
mixin.btn-icon
modifier).btn-no-outline
modifierRemaining tasks or bugs
.bg-*
to.list-group-*
). Correcting the line breaks in #1439$container-max-widths
is different between Boosted and Boostrap v5. Also compare to https://boosted.orange.com/docs/5.1/layout/breakpoints/#available-breakpoints. See #987.$grid-gutter-widths
and$container-fluid-margin-widths
that were only in Boosted v4 (and with different mixins). They are already in Boosted v5 ($container-fluid-margin-widths
->$container-fluid-margin
) since #987..table
on reboot. Do we need to change it ? -> No.display-5
/.h5
and.display-6
/.h6
have the same rendering. -> Should be hidden but not removed. Then wait for design to have specs. -> See #1496. We maybe need to update migration guide.Docs > Content > Typography Check that it's normal that we don't use in Boosted$display-font-sizes
. -> Yes that's normal since we don't use responsive font-size and we still want a kind of responsiveness on certain breakpoints. We maybe need to update migration guide.Docs > Content > Typography Missing Orange square list from v4? Linked to #1156. Seen : Feels right at the moment. We maybe need to update the migration guide.MissingLinks from v4? -> Keep it as-is since we already redirect to other components.padding-bottom
is 15px instead of 10px, top is 14px instead of 5px, 7px or 10px (depending on the content) > table-sm seems way more brand friendly on this point, shall it become the Orange base? -> No, we need both of them..rounded
is not applied. Just check if it is normal / by design. ->.rounded
isn't in Boosted anymore. Moreover, design doesn't have any rounded border apart pill and circle. To summarize, this is fine to not have rounded border until design refactor borders..rounded
class does nothing while it worked in Bootstrap v4. -> Removed from Boosted since https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/commit/a94291b258b640ee86f8c4a58185c10ba46abaef. Do we re-introduce it ? -> See #1551.Docs > Forms > Overview Padding inside input should be 9px 10px 13px instead of 7px 10px 9px (in version 5) -> Do we change it since it is well displayed this way ?is-required
should have amargin-left
of 3px instead of 6px (in version 5). See #1144 and #1177.File input Inform designers that there is no corresponding design specs.Asked to design, specs should come with accessibility aswell. Fine as it is at the momentmultiple
select. -> Let's wait for specs from design[Bootstrap] Docs > Forms > Checks & radios Radios. Probably "selected" rather than "checked" (source? https://www.w3schools.com/tags/att_input_type_radio.asp) Asked in https://github.com/twbs/bootstrap/pull/35563Checked.(no design specs). The alerts are well displayed and have 15px between in small version. See #1165.breadcrumb bg-dark
in the v4.-> See #1446.#1448#1611.Docs > Components > Buttons Missing Toggle buttons with icon example? -> Replaced by toggle-buttons in Forms directly. Do we need to change/link to something here ? -> NoDocs > Components > Button group Why Nesting and Vertical variation use a split button while Boosted v4 and Bootstrap v4/v5 uses a simple dropdown? -> To show that it even works with split dropdowns #645. Do we need to reintroduce them ? -> NoDocs > Components > Card Text alignment was removed in Boosted v4. But it wasn't maybe a good idea given the fact that it is used after in Navigation. -> Was done on purpose in #575. Do we backport it on v5 ? -> No.bg-dark
is used in Bootstrap without changing the color. In Boosted 4 it is displayed in black, in Boosted 5 it is removed. But the color comes from the SVG. Check that there is not a problem here. -> See #1493.<details>
? (see https://developer.mozilla.org/fr/docs/Web/HTML/Element/details). See #1097.Docs > Components Jumbotron doesn't exist anymore as a component in Bootstrap 5 but in examples. Add it as well in Boosted v5 for projects. -> Do we need to add an example or a component ? -> No:before
in next button, shouldn't be a:after
? -> Not important at all + simplify CSSDocs > Components > Pagination Click on selected value doesn't show pressed state. -> v5 implementation seems to be slightly better since clicking on the button shouldn't have any effect. Need a backport to v4 -> NoDocs > Components > Pagination Why numbers are not in the examples in Boosted? -> As far as I can go, removed from the doc. Do we need to reintroduce them in Boosted -> No.has-label
class in Boosted v5. Is it in the migration guide? -> Needs to be in migration guide. See #1633.Docs > Boosted migration This page doesn't exist in Boosted v5. Decide if things must be added into Bootstrap's one or by adding a new page, like it was done between v3 and v4. -> Use Bootstrap's one.> :last-child { margin-bottom: 0; }
to prefer using utilities -> No.navbar-brand + .navbar-brand
-> No$container-fluid-margin-widths
-> See #1633.em
, unlike in v4 -> No$orange-2
changed to$accessible-orange
, etc. See #1633.$alert-icons
map (to document?) with icon handling -> No since it doesn't change any use case$background-colors
replaces$supporting-colors
-> See #1633..o-link-arrow
) is now link with chevron (.link-chevron
) -> See #1633..back
has not been implemented since it's not part of the Web UI Kit. -> See #1633..btn-icon
modifier, -> See #1633..btn-icon
modifier too. -> See #1633..o-stepbar
) is now Stepped process (.stepped-process
) and all.stepbar-...
classes are now.stepped-process-...
-> See #1633.$o-stepbar-margin-r
is renamed$step-item-margin-end
-> See #1633.$o-stepbar-arrow-width
is renamed$step-item-arrow-width
-> See #1633.$o-stepbar-height
is not used anymore -> See #1633..o-footer-*
to some new.footer-*
classes -> See #1633.theme-color-level()
mixin or$theme-color-interval
variable in your custom code in v4, those are gone in v5 and are replaced with new variables instead (as for grays in v4). Here's a compatibility table, using$color
where it could be `$primary or any other theme color.. -> Already inColor levels comparison table
| v4 | v5 | | --------------------------------------- | ----------------- | | `theme-color-level($color, -8)` | `$color-100` | | `theme-color-level($color, -6)` | `$color-200` | | `theme-color-level($color, -4)` | `$color-300` | | `theme-color-level($color, -2)` | `$color-400` | | `theme-color-level($color)` | `$color-500` | | `theme-color-level($color, 2)` | `$color-600` | | `theme-color-level($color, 4)` | `$color-700` | | `theme-color-level($color, 6)` | `$color-800` | | `theme-color-level($color, 8)` | `$color-900` |.form-group .row
/.form-group .row .top
/.form-group .row .right
to move the invalid feedback message. Need to reintegrate it? -> Not in the DSM