search

Orange-OpenSource / Orange-Confort-plus

The target of Orange Confort+ functionalities is to enhance user experience on web sites, which are already accessible, or still accessible. Orange Confort+ provides these services : Typography - user may change: font size, space between words, characters and lines, font-face to Open Dislexic Layout: cancel layout, text align left, numbering list items, modify navigation links appereance, disply a reading ruler Colors : Modify foreground/background colors Behavior: direct access to main content on page load, automatic selection of page clickable elements with a user defined delay, page scrolling on simple user on hover. Be careful, Orange Confort+ does not improve the accessibility level of a web site: blocking points still stay blocking points, with or without Orange Confort+.
https://confort-plus.orange.com/
GNU General Public License v2.0
42 stars 25 forks source link

Failed to execute 'removeChild' #236

Closed RavanH closed 4 months ago

RavanH commented 4 months ago

Hi, opening and then closing (hide) the toolbar script 4.3.3 embedded on a site, I get the following error.

TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'. at Object.setCSS (toolbar.js:6:860227) at Object.loadTheToolbar (toolbar.js:6:879956) at Object.reloadToolbar (toolbar.js:6:875901) at Object.Annulation (toolbar.js:6:746055) at HTMLButtonElement. (toolbar.js:6:834515)

I've not seen any broken toolbar functions however.

The weird thing is that while original script is called from /wp-content/plugins/orange-confort-plus/vendor/js/toolbar.min.js, the error is reported to be coming from a non-existent script file on /wp-content/plugins/orange-confort-plus/vendor/js/dist/serveur/js/toolbar.js (notice the added path and missing ".min")

The error is occurring in both Firefox 126 and in Chrome 125 (on Linux), but I have not tested other browsers.

It can be seen live on https://dev.status301.com/ (open the toolbar, then close it again)

ffoodd commented 4 months ago

Regarding path, it's coming from the sourcemaps files. I don't know if it can be customized in our build, will check.

I'll have a look at this error, but only work on Confort+ a day a week, and that was yesterday — so don't expect a fix before a few days...

RavanH commented 4 months ago

@ffoodd no worries, it does not seem to break anything... In the meantime, I've finished the first version of the WordPress plugin and submitted it for review to the WordPress.org team. It may take up to a month but when published, I'll let you know :)

RavanH commented 4 months ago

@ffoodd excellent, I'll be testing soon :) ... In the meantime, I've published a basic (working) Orange Confort+ for WordPress plugin on https://github.com/RavanH/orange-confort-plus. I've not used the Orange logo but did include copies of the example images that are used on https://confort-plus.orange.com/. I also chose to use the full name 'Orange Confort+" in the plugin title. Please let me know if it is alright or not and I'll adapt asap!