For PHP7,Giving error while performing MAKE command

arjunnikhil03 commented 8 years ago

/home/xyz/YACassandraPDO/cassandra_driver.cpp:803:57: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2 /home/xyz/YACassandraPDO/cassandra_driver.cpp:808:66: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2 /home/xyz/YACassandraPDO/cassandradriver.cpp:64: error: invalid conversion from ‘int ()(pdo_dbht, const char_, long int, pdo_stmtt, zval)’ to ‘int ()(pdo_dbht, const char_, size_t, pdo_stmtt, zval_)’ /home/xyz/YACassandraPDO/cassandradriver.cpp:64: error: invalid conversion from ‘long int ()(pdo_dbht, const char_, long int)’ to ‘zendlong ()(pdo_dbht, const char_, size_t)’ /home/xyz/YACassandraPDO/cassandradriver.cpp:64: error: invalid conversion from ‘int ()(pdo_dbht, const char_, int, char_, int, pdo_paramtype)’ to ‘int ()(pdo_dbht, const char_, size_t, char__, sizet, pdo_param_type)’ /usr/include/php/Zend/zend_API.h: In function ‘int pdo_cassandra_get_error(pdo_dbht, pdo_stmtt, zval_)’: /usr/include/php/Zend/zend_API.h:432: error: too many arguments to function ‘int add_next_indexstring(zval, const char_)’ /home/xyz/YACassandraPDO/cassandra_driver.cpp:87: error: at this point in file /home/xyz/YACassandraPDO/cassandra_driver.cpp: In function ‘std::string pdo_cassandra_get_first_sub_pattern(const std::string&, const std::string&)’: /home/xyz/YACassandraPDO/cassandradriver.cpp:389: error: cannot convert ‘char’ to ‘zendstring’ for argument ‘1’ to ‘pcre_cacheentry pcre_get_compiled_regex_cache(zendstring)’ /home/xyz/YACassandraPDO/cassandra_driver.cpp:393: error: ‘MAKE_STD_ZVAL’ was not declared in this scope /home/xyz/YACassandraPDO/cassandra_driver.cpp:394: error: ‘ALLOC_INIT_ZVAL’ was not declared in this scope /usr/include/php/Zend/zendhash.h:156: error: too many arguments to function ‘zval zend_hash_indexfind(const HashTable, zend_ulong)’ /home/xyz/YACassandraPDO/cassandra_driver.cpp:402: error: at this point in file /home/xyz/YACassandraPDO/cassandra_driver.cpp:402: error: no match for ‘operator==’ in ‘zend_hash_indexfind(((const HashTable)sub_patterns->_zval_struct::value._zend_value::arr), 1u) == (ZEND_RESULT_CODE)0’ /home/xyz/YACassandraPDO/cassandra_driver.cpp:403: error: ‘Z_TYPE_PP’ was not declared in this scope /home/xyz/YACassandraPDO/cassandra_driver.cpp:404: error: ‘Z_ARRVAL_PP’ was not declared in this scope /home/xyz/YACassandraPDO/cassandra_driver.cpp:407: error: ‘Z_STRVAL_PP’ was not declared in this scope /home/xyz/YACassandraPDO/cassandradriver.cpp:414: error: cannot convert ‘zval**’ to ‘zval’ for argument ‘1’ to ‘void _zval_ptrdtor(zval)’ /home/xyz/YACassandraPDO/cassandradriver.cpp:415: error: cannot convert ‘zval**’ to ‘zval’ for argument ‘1’ to ‘void _zval_ptrdtor(zval)’ /home/xyz/YACassandraPDO/cassandra_driver.cpp: In function ‘int pdo_cassandra_handle_set_attribute(pdo_dbht, long int, zval_)’: /home/xyz/YACassandraPDO/cassandra_driver.cpp:659: error: ‘Z_BVAL_P’ was not declared in this scope /home/xyz/YACassandraPDO/cassandra_driver.cpp: In function ‘int pdo_cassandra_handle_get_attribute(pdo_dbht, long int, zval_)’: /home/xyz/YACassandraPDO/cassandra_driver.cpp:803: error: ‘ZVAL_STRING’ was not declared in this scope /home/xyz/YACassandraPDO/cassandra_driver.cpp:808: error: ‘ZVAL_STRING’ was not declared in this scope make: *\ [cassandra_driver.lo] Error 1

sandro-lex commented 8 years ago

Hello, PHP7 is not supported by YACassandraPDO.

Check the new datastax driver: https://github.com/datastax/php-driver

arjunnikhil03 commented 8 years ago

Hello YACassandraPDO, Can you please provide a support for PHP7 and Cassandra Latest Version. I know that Datastax is providing PHP-Driver, But it has issue for adaptive swamping Process of PHP-FPM.

simonhf commented 8 years ago

I too would like YACassandraPDO to support PHP7 because I also cannot use the Datastax software for various reasons... any chance of adding support?

mathieu-lornac commented 8 years ago

I do not work at Orange anymore but I will have a look at it this week. If the differences with php6 are not too big, I should be able to find some time to make the fix

simonhf commented 8 years ago

Thanks!

AFAIK YACassandraPDO relies on thrift and late last year a Facebook dev called 'dsp' added a PHP 7 version of php_thrift_protocol [1] which was pulled into the Apache Thrift project on github. I tried building the head of Apache Thrift but their are C++ errors where Googling does not seem to help. So I tried building 'dsp's fork/branch [2] and that builds but mysteriously although ./configure says it will build the PHP library, it does not get built and there are no errors either :-( I'm still looking into this...

[1] https://github.com/dsp/thrift/commit/bc24cb7cf8aa8512dcbe085ef976dffe90b76eed [2] https://github.com/dsp/thrift/tree/php7

simonhf commented 8 years ago

Scratch that last message. Why? I tried rebuilding YACassandraPDO for PHP 5.6 with a Thrift built --without-php, i.e. just the C/C++ library. YACassandraPDO built and tested just fine... so it obviously just uses the Thrift C/C++ library and not the Thrift PHP interface. So I think Apache Thrift 0.9.2 should work just fine without using the PHP 7 version of Thrift mentioned in the above message.

simonhf commented 8 years ago

So trying to compile [1] against PHP 7 results in many errors because PHP 7 has changed things up a little bit. Trying to figure out if I can hack it to work...

$ time make
/bin/sh /home/dev/share/20160418-php7/YACassandraPDO-master/libtool --mode=compile g++ -Wall -Wno-write-strings -I/usr/include/php/ext -I. -I/home/dev/share/20160418-php7/YACassandraPDO-master -DPHP_ATOM_INC -I/home/dev/share/20160418-php7/YACassandraPDO-master/include -I/home/dev/share/20160418-php7/YACassandraPDO-master/main -I/home/dev/share/20160418-php7/YACassandraPDO-master -I/usr/include/php -I/usr/include/php/main -I/usr/include/php/TSRM -I/usr/include/php/Zend -I/usr/include/php/ext -I/usr/include/php/ext/date/lib -I/usr/local/include  -DHAVE_CONFIG_H  -g -O2   -c /home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp -o cassandra_driver.lo 
libtool: compile:  g++ -Wall -Wno-write-strings -I/usr/include/php/ext -I. -I/home/dev/share/20160418-php7/YACassandraPDO-master -DPHP_ATOM_INC -I/home/dev/share/20160418-php7/YACassandraPDO-master/include -I/home/dev/share/20160418-php7/YACassandraPDO-master/main -I/home/dev/share/20160418-php7/YACassandraPDO-master -I/usr/include/php -I/usr/include/php/main -I/usr/include/php/TSRM -I/usr/include/php/Zend -I/usr/include/php/ext -I/usr/include/php/ext/date/lib -I/usr/local/include -DHAVE_CONFIG_H -g -O2 -c /home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp  -fPIC -DPIC -o .libs/cassandra_driver.o
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:803:57: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:808:66: error: macro "ZVAL_STRING" passed 3 arguments, but takes just 2
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:64: error: invalid conversion from 'int (*)(pdo_dbh_t*, const char*, long int, pdo_stmt_t*, zval*)' to 'int (*)(pdo_dbh_t*, const char*, size_t, pdo_stmt_t*, zval*)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:64: error: invalid conversion from 'long int (*)(pdo_dbh_t*, const char*, long int)' to 'zend_long (*)(pdo_dbh_t*, const char*, size_t)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:64: error: invalid conversion from 'int (*)(pdo_dbh_t*, const char*, int, char**, int*, pdo_param_type)' to 'int (*)(pdo_dbh_t*, const char*, size_t, char**, size_t*, pdo_param_type)'
/usr/include/php/Zend/zend_API.h: In function 'int pdo_cassandra_get_error(pdo_dbh_t*, pdo_stmt_t*, zval*)':
/usr/include/php/Zend/zend_API.h:432: error: too many arguments to function 'int add_next_index_string(zval*, const char*)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:87: error: at this point in file
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp: In function 'std::string pdo_cassandra_get_first_sub_pattern(const std::string&, const std::string&)':
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:389: error: cannot convert 'char*' to 'zend_string*' for argument '1' to 'pcre_cache_entry* pcre_get_compiled_regex_cache(zend_string*)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:393: error: 'MAKE_STD_ZVAL' was not declared in this scope
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:394: error: 'ALLOC_INIT_ZVAL' was not declared in this scope
/usr/include/php/Zend/zend_hash.h:156: error: too many arguments to function 'zval* zend_hash_index_find(const HashTable*, zend_ulong)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:402: error: at this point in file
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:402: error: no match for 'operator==' in 'zend_hash_index_find(((const HashTable*)sub_patterns->_zval_struct::value._zend_value::arr), 1u) == (ZEND_RESULT_CODE)0'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:403: error: 'Z_TYPE_PP' was not declared in this scope
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:404: error: 'Z_ARRVAL_PP' was not declared in this scope
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:407: error: 'Z_STRVAL_PP' was not declared in this scope
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:414: error: cannot convert 'zval**' to 'zval*' for argument '1' to 'void _zval_ptr_dtor(zval*)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:415: error: cannot convert 'zval**' to 'zval*' for argument '1' to 'void _zval_ptr_dtor(zval*)'
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp: In function 'int pdo_cassandra_handle_set_attribute(pdo_dbh_t*, long int, zval*)':
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:659: error: 'Z_BVAL_P' was not declared in this scope
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp: In function 'int pdo_cassandra_handle_get_attribute(pdo_dbh_t*, long int, zval*)':
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:803: error: 'ZVAL_STRING' was not declared in this scope
/home/dev/share/20160418-php7/YACassandraPDO-master/cassandra_driver.cpp:808: error: 'ZVAL_STRING' was not declared in this scope
make: *** [cassandra_driver.lo] Error 1

real    0m1.697s

[1] https://github.com/Orange-OpenSource/YACassandraPDO/archive/master.zip

mathieu-lornac commented 8 years ago

PHP7 internal API has changed a lot. The implementation is not complete yet, decimal support and NULL values are not handled properly.

If you want to give it a try, you can find the source code on my GitHub. https://github.com/mathieu-lornac/YACassandraPDO

Though I was the maintainer of the project when I worked at Orange I no longer have access to the original repository.

If you experience any issues, please give me detailed information on the problem you encontered.

simonhf commented 8 years ago

FYI there is another PHP 7 port here [1] which has all existing functionality ported, a bug fixed in the old decimal support code, and all tests passing :-)

[1] https://github.com/bixuehujin/YACassandraPDO/tree/php7

mathieu-lornac commented 8 years ago

I wish I knew that a few days ago ^^ Sandro, could you add this link to the README page of the project?

sandro-lex commented 8 years ago

Done.

Thanks guys!

blackdotsh commented 8 years ago

I actually have issues with bixuehujin's fork. I can insert into a set but when I try to get the set with a select command it returns a empty array. Other variable types seem to work with reads & writes (string, int, float).

simonhf commented 8 years ago

IIWY I'd code up a new failing test which works with the pre-fork code, but fails with the fork code. This would be a good starting place to get the code fixed.

blackdotsh commented 8 years ago

pre-fork code gives the correct output and the post fork code gives an empty array (wrong output).

1) I create a row with some value ( google.com ) 2) I insert an additional item to the same set on the same row ( yahoo.com ) 3) I print out the results

Pre-fork: Array ( [0] => google.com [1] => yahoo.com )

post fork

Array ( )

Both of them seem to insert the value to the database without any issues because I verified it using cqlsh, but post-fork can't seem to handle the result of the select statement.

simonhf commented 8 years ago

Are you sure this isn't covered by the existing unit tests which incidentally all work with the post fork code? It seems like a very basic issue, or? Can you post minimal code which reproduces the issues?

blackdotsh commented 8 years ago

This is the code that I used. CASSANDRA_IP needs to be replaced with your Cassandra cluster IP(s).

<?php
//
//with cqlsh, create the following keyspace & table
// CREATE KEYSPACE testkeyspace WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
// create table settest ( ip inet primary key, value set<text> ) WITH compression = { 'sstable_compression' : 'LZ4Compressor', 'chunk_length_kb' : 64 };

$dsn = "cassandra:host=CASSANDRA_IP;port=9160";
 $db = new PDO($dsn);
 $db->exec("USE testkeyspace");

$ipaddr = "127.0.0.1";
$value= "google.com";

//create the initial row
$stmt = $db->prepare("INSERT into settest (ip, value) values (:ipval, { :val } ) ;");
        $stmt->bindValue(':ipval', $ipaddr, PDO::PARAM_STR);
        $stmt->bindValue(':val', strval($value), PDO::PARAM_STR);
        $stmt->bindValue(':val', strval($value), PDO::PARAM_STR);
        $stmt->execute();

//append another value to the same row
$value="yahoo.com";
$stmt = $db->prepare("UPDATE settest SET value = value + { :val } WHERE ip = :ipval ;");
        $stmt->bindValue(':ipval', $ipaddr, PDO::PARAM_STR);
        $stmt->bindValue(':val', strval($value), PDO::PARAM_STR);
        $stmt->execute();

//print out the results
$checkIP= "127.0.0.1";
$stmt = $db->prepare("SELECT value from settest where ip = :ipval");
                $stmt->bindValue(':ipval', $checkIP, PDO::PARAM_STR);
                $stmt->execute();
                $result=$stmt->fetchAll()[0]['value'];
                print_r($result);

?>

I appreciate the help.

simonhf commented 8 years ago

bixuehujin added a test case [1] using the above code and unfortunately he was unable to reproduce the bug because the test passes on travis [2] for both PHP 5.6 and PHP 7. I suggest you look very carefully at what is different between the build and test run on travis, and the build and test run on your system. Good luck!

[1] https://github.com/bixuehujin/YACassandraPDO/commit/5ffb518635ba47a0dd7fdbb66c85d8a9230b4fc4 [2] https://travis-ci.org/bixuehujin/YACassandraPDO/builds/144470131

blackdotsh commented 8 years ago

Thanks Simon. I'll see what I did wrong.

simonhf commented 8 years ago

Please keep me in the loop.

blackdotsh commented 8 years ago

I started with a clean Debian 8 install on a dev machine. Installed Cassandra and the following packages for dotdeb repo. php7.0 php7.0-fpm php-pear php7.0-common php7.0-cli php7.0-gd nginx-full php7.0-curl

Downloaded https://github.com/bixuehujin/YACassandraPDO/archive/php7.zip and proceeded to install.

Besides the instructions that were already outlined in [1], here's what I did differently to get everything to build

Error on ./configure: checking for PDO includes... configure: error: Cannot find php_pdo_driver.h fixed by doing ln -s /usr/include/php/20151012/ext ext

YACassandraPDO/gen-cpp/Cassandra.h:10:39: fatal error: thrift/TDispatchProcessor.h: No such file or directory fixed by doing apt-get install thrift-compiler=0.6.0-2~riptano1 so an older version of thrift is used instead of version 0.9

Once complete, I run run-tests.php and received the following output

I see that on travis, the build was done on Ubuntu 16.04 LTS. I will spin up a VM or just reformat my dev system and see if it makes any difference. At this point, I think I did something wrong with php pdo (by doing a soft link on ./configure ?) or dotdeb's php 7 is drastically different from Ubuntu 16.04's. It's very strange to have a partially working driver with 4 failed tests and 32 passed tests.

[1] https://code.google.com/archive/a/apache-extras.org/p/cassandra-pdo

simonhf commented 8 years ago

Thanks for the detailed info. I'm not sure what the problem is but my money would be on the thrift stuff causing the problem. And IMO that could be something that affects some tests but not others? Try to use exactly the same version of thrift that travis is using. And after changing the thrift version, recompile all the source code from scratch.

blackdotsh commented 8 years ago

Simon,

Your comment prompted me to look at all the version differences of every piece of software involved between my dev server and the travis build, which led me to the issue: I downloaded the latest version of Cassandra version 3.x instead of using the older 2.xx. I use 2.xx on my production servers and on the dev server, I just upgraded everything to the latest version. Downgrading or starting with Cassandra version 2.xx passes all tests.

The following workarounds for the errors during build time still work for me

Error on ./configure: checking for PDO includes... configure: error: Cannot find php_pdo_driver.h fixed by doing ln -s /usr/include/php/20151012/ext ext

YACassandraPDO/gen-cpp/Cassandra.h:10:39: fatal error: thrift/TDispatchProcessor.h: No such file or directory fixed by doing apt-get install thrift-compiler=0.6.0-2~riptano1 so an older version of thrift is used instead of version 0.9

Hopefully someone will find this information useful :)

Thanks.

simonhf commented 8 years ago

Glad to be able to prompt you in the right direction and good to know what the issue is!

simonhf commented 7 years ago

BTW the old SSL patch has been merged into [1] with all the tests passing BUT hasn't been properly tested yet with production code... so try it and report back here? :-)

https://github.com/bixuehujin/YACassandraPDO/tree/php7

Orange-OpenSource / YACassandraPDO

For PHP7,Giving error while performing MAKE command #91