search

Orange-OpenSource / angular-swagger-ui

An angularJS implementation of Swagger UI
http://orange-opensource.github.io/angular-swagger-ui/
MIT License
135 stars 74 forks source link

Use angular-bootstrap instead of angular-ui-bootstrap #75

Closed glenwinters closed 6 years ago

glenwinters commented 7 years ago

I'm using main-bower-files during my build process to get the files specified by the "main" property of bower.json for every bower dependency. For angular-ui-bootstrap, which angular-swagger-ui requires, it's getting bower_components/angular-ui-bootstrap/index.js which is not a correct client-side JS file, and it's causing a crash in my build. I noticed that angular-ui-bootstrap doesn't even have a bower.json file.

The README for angular-ui-bootstrap specifies here that you should install angular-bootstrap, not angular-ui-bootstrap via bower. angular-bootstrap does have a bower.json file with the "main" property pointing to a usable client-side JS file.

Is there a reason angular-swagger-ui is requiring angular-ui-bootstrap instead of angular-bootstrap?

Thanks!

mathieuales commented 7 years ago

Hi ! I'm using angular-ui-bootstrap instead of angular-bootstrap because you can choose which components you use. This module is only required if you use module swagger-authentication This module should maybe only be used in dev mode, I'll put it in devDependencies. Regards

glenwinters commented 7 years ago

Since the authentication module is not included by default, I agree that angular-ui-bootstrap shouldn't be in the main dependencies. Thanks for the response.

In the meantime, I was able to get around this problem by ignoring the dependency via .bowerrc: ignoredDependencies: ["angular-ui-bootstrap"]