Closed erdrix closed 4 years ago
Open an issue on admiralty side to be able to upgrade some k8s dependencies for multi-casskop operator : https://github.com/admiraltyio/multicluster-controller/issues/3
Note : Not required for the merge.
Patch overall looks good to me!
@erdrix unfortunately you think unit tests but they don't. We need to replace the --namespace
argument in unit tests by --operator-namespace
and also update unit tests to use the context argument when calling the k8s API. See my changes ace1baa and 6a6c947.
There is also an annoying change in the 1.18 API, see the third one at https://kubernetes.io/docs/setup/release/notes/#other-api-changes that prevents us from running it on k8s 1.18 atm. If you can make the changes and take a look at it it'd be great. It relates to the sidecars configuration
time="2020-06-03T22:38:20Z" level=fatal msg="failed to create resource(s) in global resource manifest: CustomResourceDefinition.apiextensions.k8s.io \"cassandraclusters.db.orange.com\" is invalid:
spec.validation.openAPIV3Schema.properties[spec].properties[sidecarConfigs].items.properties[ports].items.properties[protocol].default: Required value:
this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property"
What's in this PR?
This PR is related to the #222 one, It's about upgrade some dependencies :
Why?
To be able to deploy the operator on the latest kubernetes cluster versions.
Checklist