search

Orange-OpenSource / casskop

This Kubernetes operator automates the Cassandra operations such as deploying a new rack aware cluster, adding/removing nodes, configuring the C* and JVM parameters, upgrading JVM and C* versions, and many more...
https://orange-opensource.github.io/casskop/
Apache License 2.0
183 stars 54 forks source link

liveness - Make separate liveness/readiness probes possible. #278

Closed toffer closed 3 years ago

toffer commented 3 years ago
Q A
Bug fix? []
New feature? [x]
API breaks? []
Deprecations? []
Related tickets fixes #277
License Apache 2.0

What's in this PR?

This PR adds back the ability to use different scripts for the liveness and readiness probes, but it preserves the default behavior (introduced in #234) where the same script is used for both.

The readiness-probe.sh script will continue to be used for both the liveness and readiness probes, since liveness-probe.sh is a symlink to readiness-probe.sh.

However, by using separate filenames for each of the probes, it is now possible to override this behavior, and define separate scripts for each type of probe.

Checklist

toffer commented 3 years ago

For the dgoss test to pass, this will require building a new bootstrap docker image (version 0.1.7).

cscetbon commented 3 years ago

I wanted to simplify it but I think it makes sense if you want to overwrite it. I’ll generate the bootstrap image and kick off the tests again