search

Orange-OpenSource / casskop

This Kubernetes operator automates the Cassandra operations such as deploying a new rack aware cluster, adding/removing nodes, configuring the C* and JVM parameters, upgrading JVM and C* versions, and many more...
https://orange-opensource.github.io/casskop/
Apache License 2.0
183 stars 54 forks source link

Fix issue #374 with determining the cassandra version from image #375

Closed ibumarskov closed 2 years ago

ibumarskov commented 2 years ago
Q A
Bug fix? [+]
New feature? [-]
API breaks? [-]
Deprecations? [-]
Related tickets fixes #374
License Apache 2.0

What's in this PR?

Fix cassandra version definition in case we have custom port for image repository.

cscetbon commented 2 years ago

Please add a unit test to ensure it works as expected in 2/3 different cases.

ibumarskov commented 2 years ago

Please add a unit test to ensure it works as expected in 2/3 different cases.

Done, pls review

cscetbon commented 2 years ago

I got some permissions issues to trigger all our tests and have to wait to get someone on it and fix it.

fdehay commented 2 years ago

Hello @ibumarskov , Could you please rebase your branch on master please? We have pushed a small fix today to have integration tests work that we need before accepting PRs Sorry for this Thanks!