search

Orange-OpenSource / casskop

This Kubernetes operator automates the Cassandra operations such as deploying a new rack aware cluster, adding/removing nodes, configuring the C* and JVM parameters, upgrading JVM and C* versions, and many more...
https://orange-opensource.github.io/casskop/
Apache License 2.0
183 stars 54 forks source link

[Backup] Do not validate Secret for file protocol #379

Closed AKamyshnikova closed 2 years ago

AKamyshnikova commented 2 years ago

File protocol does not need any authentication, but backup will fail if secret is not set. Check protocol type before validating secret.

Fixes #378

Q A
Bug fix? [x]
New feature? []
API breaks? []
Deprecations? []
Related tickets fixes #X, partially #Y, mentioned in #Z
License Apache 2.0
fdehay commented 2 years ago

Hello @AKamyshnikova, Could you please rebase your branch on master please? We have pushed a small fix today to have integration tests work that we need before accepting PRs Sorry for this Thanks!

AKamyshnikova commented 2 years ago

@fdehay Hi! I've rebased change on master.

cscetbon commented 2 years ago

@fdehay looks good to me. We should test that a regular backup still works as it's not tested here. other than that 👍

cscetbon commented 2 years ago

@AKamyshnikova it seems part of this code is already included in the volume mounts PR. Is it because the other PR is branched off of this one ?

AKamyshnikova commented 2 years ago

@cscetbon Hi! Yes, I just based it on top of this. I could rebase on master the other one when this is merged.