search

Orange-OpenSource / casskop

This Kubernetes operator automates the Cassandra operations such as deploying a new rack aware cluster, adding/removing nodes, configuring the C* and JVM parameters, upgrading JVM and C* versions, and many more...
https://orange-opensource.github.io/casskop/
Apache License 2.0
183 stars 54 forks source link

Improve change detection on monitored objects #69

Open allamand opened 5 years ago

allamand commented 5 years ago

We currently don't checks if all existings objects may have changed before updating thems.

We are doing it for statefulset and also prevent some changes on statefulsets for many reasons (ongiing disruptions, onging scaledown...).

The way we check is statefulset needs to be updated, may be error prone, and guys from Banzaicloud release a tool to help with that.

This issue is to see if their library could be useful for out statefulset upgrade mechanism, and also we may see if it can apply to other managed objects (services..)

there is the library : https://github.com/banzaicloud/k8s-objectmatcher

cscetbon commented 5 years ago

@allamand I really like it. It's definitely an issue and I had to fix it in multiple places. If we have a library that handles it for us 🎉

allamand commented 5 years ago

https://github.com/Orange-OpenSource/cassandra-k8s-operator/pull/99/files#diff-37aff102a57d3d7b797f152915a6dc16R22