search

Orange-OpenSource / conllueditor

ConllEditor is a tool to edit dependency syntax trees in CoNLL-U format.
BSD 3-Clause "New" or "Revised" License
54 stars 17 forks source link

Search for empty nodes? #16

Closed francescomambrini closed 2 years ago

francescomambrini commented 2 years ago

I would like to review all the empty nodes in my treebank. According to the help page, it should be possible to use the Empty key (no value) in the advanced search field. However, if I try, I get the error: CoNLL-U error: line 1:0 token recognition error at: 'Em'.

Am I missing anything? Is there any other way to do this?

Thank you very much for your support!

jheinecke commented 2 years ago

Hi, there is indeed a problem, I'll have a look at this, it must have slipped through the tests.

jheinecke commented 2 years ago

Fixed ! There was something missing (which was not tested). Try

git pull
mvn install
jheinecke commented 2 years ago

I forgot: for the search its IsEmpty not just "Empty" (I had to change that a while ago)

francescomambrini commented 2 years ago

Thank your for the very quick fix! Right now I am only able to test with Docker. With IsEmpty I no longer get the previous error, but the query returns no results (and I do have a few empty nodes here and there). But the problem might be with the data: I'll have to do some more in-depth testing...

jheinecke commented 2 years ago

I didn't push the docker image yet. I'll do it as soon as possible, sorry for that

francescomambrini commented 2 years ago

Of course! silly me, I didn't think that the Docker image too needed to be updated... :blush:

jheinecke commented 2 years ago

done !

francescomambrini commented 2 years ago

It works! (built with mvn and tested)