Orange-OpenSource / conllueditor

ConllEditor is a tool to edit dependency syntax trees in CoNLL-U format.
BSD 3-Clause "New" or "Revised" License
54 stars 17 forks source link

Streamlining the installation #24

Closed Stormur closed 1 year ago

Stormur commented 2 years ago

Hi!

The current way of installing of conllueditor seems to be a major hurdle for many users who are not so keen or practical on the more technical details, especially with regard to Windows. So I was wondering if it is possible to help this process a bit:

I am further wondering if:

I am reporting you that because in my experience this first step is the biggest, if not unsurmountable, problem for many users.

Thank you for all your support!!!

jheinecke commented 2 years ago

Yes, I agree, there is room for improvement :-). I do not use Windows very often, but I could provide a compiled .jar file which avoids local compilation, and replacing the links to jquery etc to public sites (however when using public sites for jquery, the editor would not work without internet connection, so I'm not sure whether this is a good idea. I'll have a look in making a installJQ.bat for windows users too. However node and npm is not used :-)

Stormur commented 2 years ago

Darn, I thought it was needed and I installed it because it was the way I found to install the single java scripts before noticing the practical bash! :grimacing:

The online constriction might be a viable compromise for some users.

jheinecke commented 2 years ago

Hi again, I made a release in order to facilitate the installation. Everything needed is compiled and put into a simple zip-file. Should be straight forward for Linux, for Windows I'm not sure whether the command line works (cannot test it here). Please try and telle me what you think of it.

Stormur commented 2 years ago

Great as always, thanks!

We are launching some new annotations, so we will check this new method!

Stormur commented 2 years ago

OK, first note: it seems that the latest Windows version refuses to run and to modify the new .cmd file. Howver, if we create an equivalent .bat, it works without problems.

Also, the validator file for Windows seems to require that python is called before validator.py (so something like script: py <...>\validator.py ...)

jheinecke commented 2 years ago

Hi created a new pre-release and changed the ce.cmd to ce.bat (and corrected some issues for Linux too. This replaces the first pre-release. I hope this servers you better

Stormur commented 2 years ago

I have been trying to run the editor on my old Windows (10) laptop, but it does not seem to work. I have updated java.

I downloaded the conllueditor-master (is this the mentioned "a.b.c."?) folder, unzipped it and just tried to launch it with

.\bin\conlluedit.sh --rootdir .\gui\ .\file.conllu 8888

A terminal window opened briefly and then closed; the server is not reachable.

Am I missing something?

jheinecke commented 2 years ago

Unless you have WSL or cygwin installed bin\conlluedit.sh will not work, since, to my knowledge, there is no bash interpreter on Windows. So in this case either use the ce.bat script or try to run

java -jar conllueditor-2.16.2\target\ConlluEditor-2.16.2-jar-with-dependencies.jar --rootdir conllueditor-2.16.2/gui treebank.conllu 8888
Stormur commented 2 years ago

I have WSL, but maybe I have to install a specific Linux distribution. It seems that the Powershell can handle those sh, though. I'll try!

Stormur commented 1 year ago

Dear @jheinecke ,

I am trying to run conllueditor on another Windows machine, but we are not able to make it work. We are trying to run the bat file, but it outputs an error, apparently because the username in the string C:\Users\USERNAME\... contains a space.

So I have two main issues/questions:

jheinecke commented 1 year ago

Hi, I guess the easiest way is to start the server without the .bat script on a commandline using quotes

java -jar "C:\Users\USERNAME\...\ConlluEditor-2.21.1-jar-with-dependencies.jar" [options]  yourfile.conllu 5556

Do you try it on pure Windows or within a WSL? For the latter case the bin/conlluedit.sh should work, but obviously I didn't try with blanks in the path. You could try to modify bin/conlluedit.sh an put quotes around $NEWESTJAR and $ROOTDIR:

java -Xmx4g -cp "$NEWESTJAR" com.orange.labs.editor.ConlluEditor "${ROOTDIR}" "$@"
Stormur commented 1 year ago

Do you try it on pure Windows or within a WSL?

We are trying it on a "pure" Windows, I think (no WSL installed), from the Powershell.

jheinecke commented 1 year ago

did putting the variables within quotes help?

Stormur commented 1 year ago

Sorry, we'll have to retry as soon as possible, we were not able to go on yet.

I will also try the "experiment" on a Windows device of mine (the same I mentioned in previous posts, on which it seems that I was not able to make conllueditor run).

I will let you know!

Stormur commented 1 year ago

OK, everything works smoothly but a couple of apparent bugs (new issue incoming)!

It was my bad that I had not noticed that the latest release on the right of the page is not the same as the master repository, that is why I was confused about the jar! My suggestion thus could be to make it clearer for Windows user where the needed zip is :slightly_smiling_face:

Thanks for all the support as always!