Orange-OpenSource / conllueditor

ConllEditor is a tool to edit dependency syntax trees in CoNLL-U format.
BSD 3-Clause "New" or "Revised" License
54 stars 17 forks source link

Shortcuts and table view #38

Closed Stormur closed 3 months ago

Stormur commented 5 months ago

I am noticing this strange bug: in table view, when selecting a row and using a shortcut from the keyboard, not too infrequently the tag is assigned to another (random?) token. I wonder why this happens.

And about shortcuts:

Thank you as always! :pray:

jheinecke commented 5 months ago

To remove all features (FEAT) of a word, mark the word and type _. I'll see how I can keep the word marked for further shortcuts. Maybe a second way to mark (and and unmark) to keep the current way as it is. I'll also check for the bug. Didn't observe it yet, but I'm more on tree view

Stormur commented 5 months ago

More about that bug: I have noticed that sometimes it gives me an "out of bound" error, for example trying to reach token 65 when there are only 50. It seems that somehow a count goes on behind the scenes, and often the obtained number corresponds to an existing token's id, so it applies the shortcut to it. I would say it happens at least 1 out of 10 times.

jheinecke commented 5 months ago

What does your shortcut change: UPOS, UPOX+XPOS, FEAT or deprel ? I try to reproduce it, without success so fat

Stormur commented 5 months ago

I am using them for UPOS, features and miscellaneous. It seems to happen in each case.

To remove all features (FEAT) of a word, mark the word and type _.

Can this be implemented for MISC, too?

jheinecke commented 5 months ago

That exists already (but was missing in the documentation) / deletes all key=values from the MISC column. I found the reason for the bug: There is a reinitialisation missing, so if you click on an ID and than choose a new sentence before issuing a shortcut, the ID clicked originally is used (and not the new one). I corrected this and push it ASAP

jheinecke commented 5 months ago

See version 2.25.3. Only thing missing is the keep the word marked feature. I'll have to think how to do it the best way. Eithe a checkbutton (which has to be active) or a Shift-Click on the word. What to you think is more practical?

Stormur commented 5 months ago

Since this works with shortcuts, I would prefer the keyboard option, so maybe shift!

jheinecke commented 4 months ago

It took a little while, but I've just pushed V2.25.4 In table view Ctrl-Click marks a word for short cut and it stays marked until you change the sentence or click another word