search

Orange-OpenSource / hasplayer.js

Http Adaptive Streaming javascript player based on HTML5 premium extensions (MSE/EME)
Other
198 stars 67 forks source link

Some fixes to support QtWebKit port #202

Closed onotole closed 6 years ago

bbert commented 6 years ago

Hi, Thanks for your contribution. However, your PR mixes different topics. Please for provide one PR for each subject. Also, please detail the reason for your last commit 078933ed098d3005ef12b0022498966366f72ad5 . This change will break the player on some browsers like IE.

onotole commented 6 years ago

Hi Bertrand,

Sure, I've got you point - give me few days to re-sort my PRs.

The last commit, it is performance improvement (especially on my low profile box) as setting currentTime on video tag results in seek which is not trivial operation. Anyways, I can live with this change on my local branch.

Thank you, Anatoliy

On Mon, Dec 18, 2017 at 12:49 AM, Bertrand Berthelot < notifications@github.com> wrote:

Hi, Thanks for your contribution. However, your PR mixes different topics. Please for provide one PR for each subject. Also, please detail the reason for your last commit 078933e https://github.com/Orange-OpenSource/hasplayer.js/commit/078933ed098d3005ef12b0022498966366f72ad5 . This change will break the player on some browsers like IE.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Orange-OpenSource/hasplayer.js/pull/202#issuecomment-352362068, or mute the thread https://github.com/notifications/unsubscribe-auth/AAeP1MFwS-Yu0-1RDyA8h4AkjYQNq_rAks5tBicxgaJpZM4Q0FMl .

onotole commented 6 years ago

Will be sliced & diced