FourCC="AACH" does not work for smooth streaming.

Orange-OpenSource / hasplayer.js

Http Adaptive Streaming javascript player based on HTML5 premium extensions (MSE/EME)

Other

197 stars 67 forks source link

FourCC="AACH" does not work for smooth streaming. #247

Closed PatrikCarlander closed 5 years ago

PatrikCarlander commented 5 years ago

Codec AACH is not in the list of accepted coded. (SUPPORTED_CODECS) But I can play if I add it in a custom branch.

Can you please update the list to also accept AACH?

bbert commented 5 years ago

On which browser did you tried? We explicitely disabled AACH due to interoperability issues on some browsers and terminals/PCs. We made the choice to disable AACH to avoid decoding issues on some configurations, but this can be reconsidered according to browser evolutions

PatrikCarlander commented 5 years ago

I have test streams with AACH with latest Chrome, Firefox, Edge and IE11 on Windows 10. It works after I patch hasplayer SUPPORTED_CODECS = ["AAC", "AACL", "AVC1", "H264", "TTML", "DFXP", "AACH"],

bbert commented 5 years ago

The problem is that I also tested on my side some streams with AACH audio, and parsing by the browser video decoder of the MP4 initialisation segment failed. Thus, I do not feel confident to enable AACH representations. But you can still fork and modify on your side for your needs.

PatrikCarlander commented 5 years ago

Thanks