Orange-OpenSource / nifikop

The NiFiKop NiFi Kubernetes operator makes it easy to run Apache NiFi on Kubernetes. Apache NiFI is a free, open-source solution that support powerful and scalable directed graphs of data routing, transformation, and system mediation logic.
https://orange-opensource.github.io/nifikop/
Apache License 2.0
128 stars 34 forks source link

nifikop creates conf/bootstrap-notification-servces instead of conf/bootstrap-notification-services #127

Closed mh013370 closed 3 years ago

mh013370 commented 3 years ago

Bug Report

What did you do? In a nifi cluster configuration, i added some bootstrap override properties:

spec:
  readOnlyConfig:
    bootstrapProperties:
      overrideConfigs: |
        prop1=value1

In the running container, nifikop has created conf/bootstrap-notification-servces.xml, which contains a typo. Services is spelled incorrectly. In fact, this is also how it's named in the k8s secret cluster config secret.

What did you expect to see? nifikop should have created conf/bootstrap-notification-services.xml instead of conf/bootstrap-notification-servces.xml

What did you see instead? Under which circumstances? See above.

Environment

Possible Solution

Additional context Add any other context about the problem here.

mh013370 commented 3 years ago

Could be a simple one-liner: https://github.com/Orange-OpenSource/nifikop/blob/2927cf0a07e3f6e32c63bdb21c567da40caa2d12/pkg/resources/nifi/configmap.go#L61