Orange-OpenSource / ods-flutter

Flutter library of reusable graphical components for Android and iOS
https://orange-opensource.github.io/ods-flutter/
MIT License
16 stars 4 forks source link

[Bug]: Embedded pages in ZeroHeight can contain a vertical scroll bar #363

Closed julien-deramond closed 6 months ago

julien-deramond commented 6 months ago

Prerequisites

Describe the issue

When a user goes to the Develop tab of https://system.design.orange.com/0c1af118d/p/0326f8-navigation-rails/b/39a3e0 and reads the page, the embedded content is scrollable and shouldn't:

2024-03-28 07 07 43

This seems to be caused by the following style in detail.html or main.html (I don't remember which one is used for the embedded version):

html, body {
  min-height: 100vh;
}

This is to be tested in a ZeroHeight staging environment, but I'd say it's safe to remove only for the layout in "embedded mode" (pages without the _docs suffix in the URL; e.g. https://orange-opensource.github.io/ods-flutter/components/navigation_rail)

⚠️ Once it's patched in ODS Flutter, the same patch should be applied to ODS Android and ODS iOS. Linked tasks: