Orange-OpenSource / ods-ios

A SwiftUI components library with code examples for Orange Design System
https://orange-opensource.github.io/ods-ios/
MIT License
26 stars 6 forks source link

refactor the Lists variant list selection #263

Closed B3nz01d closed 1 year ago

B3nz01d commented 1 year ago

The target is to show only one variant "Lists demo" with a link to a new page with a customization bottom sheet to allow:

Example of list:

ludovic35 commented 1 year ago

@mccart77 @B3nz01d In this screen zpl.io/RMv7A6v it is not possible to have miltuple selection in Trailing Chips because

B3nz01d commented 1 year ago

based on the design review:

ludovic35 commented 1 year ago

Q1 : For standard List: is it possible to have this kind of item (zpl.io/RMv7A6v) (text and icon: i button) ? If yes, not possible to have :

Q2: the size of the image should not scale up and stay at its current height What doest it means its current height ?

@B3nz01d @mccart77 Can you clarify, please ?

B3nz01d commented 1 year ago

Q2: the size in fixed to what you see in zepplin, if the user raizes the font size, it will stay a the same initial size

B3nz01d commented 1 year ago

Q1: Yes it is possible to have text and icon at the same time. 2 options are possible:

I'd rather use the first option on my side. what do you propose @mccart77

ludovic35 commented 1 year ago

@mccart77 @B3nz01d on zeplin i can't find : spacings between "i" button on "Details" text spacing between title or subtitle and "Details" text spacing above title spacing below subtitle or title is no subtitle spacing above and below the leading image

For dynamic type fonts, Should title or/ and subtitle should be truncated or we accepte all items don't have the same height ?

Tayebsed93 commented 1 year ago

bug accessibility ticket : https://github.com/Orange-OpenSource/ods-ios/issues/298

@B3nz01d I will be able to put the label "OK Accessibility" once the ticket 298 has been corrected