Closed louismaximepiton closed 6 months ago
Name | Link |
---|---|
Latest commit | 5131d8a630d6e2ad06675bff8a0057c80ba1a0dd |
Latest deploy log | https://app.netlify.com/sites/ods-ios/deploys/65ce22681a3b6300096d7bb9 |
Deploy Preview | https://deploy-preview-697--ods-ios.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Apart from the formatting of
docs/_includes/tarteaucitron.html
, this PR LGTM! Good job @louismaximepiton. The content is the same as the one validated in ODS Android. I let the maintainers give you more info about the CI error with GitLeaks which seems to be a configuration error (upstream or maybe to do in your fork 🤷)
Indeed I defined a GItleaks action so as to look for secrets leaks in PR and repository. This feature is absed on a licence for organisations like ours. It seems the check is run in the fork side, not ours, that is the reason why it failed because of missing license.
After code review, nothing found, LGTM.
For text time, you should create a dedicated issue to as to trace these contributions.
Description
What needs to be reviewed at least
main.html
aren't breakingods-android