search

Orange-OpenSource / ouds-ios

A SwiftUI components library with code examples for Orange Unified Design System
https://ios.unified-design-system.orange.com/
MIT License
5 stars 1 forks source link

Tokens: Remove border-radius-circle at 50% #58

Closed pylapp closed 15 hours ago

pylapp commented 1 month ago

In addition to issue #30, some study should be done about what is exepeted for the semantic token "border-radius-circle" which has a value of "50%". Indeed this case is particular because it does no match at all the other types of values any borrder radius semantic token have. This case should be considered with design team.

EDIT: This token should be removed (refering this issue in CHANGELOG and Git history), and also the "pill" shape (token border-radius-9999 / 2000)

cc @julien-deramond @ludovic35

pylapp commented 1 week ago

FYI After a meeting this token should be removed. @julien-deramond You may want to recycle this issue for token deletion instead of create a new one :)

julien-deramond commented 1 week ago

This token should be removed or not implemented, and border radius pill too.