OrangeAed / NC_Historic_Companion

0 stars 0 forks source link

Creating a Footer on the site #5

Open OrangeAed opened 5 days ago

OrangeAed commented 5 days ago

This is the first issue that you will be doing! Remember all the things that you learned from our talks and the courses that you took. Your first task will not be too complex to ease you into the project, but that does not mean it won't be challenging. This is real work that will actively contribute to our web application being better.

Feature Description: I want a footer that will appear on the bottom of every screen. On the right will be the words "Created by Aedan Simons-Rudolph and Alex Gerac" and on the right will be a github icon that has a link to this github repository. For inspiration of what I am looking for, take a look at this web application: https://appmais.cs.appstate.edu/

Think about how you should accomplish this issue before you start. You only want to have to write this code once, even though it will be in many places on the website. How will you accomplish this? Is there a way that you can have this footer appear everywhere on the application while only having to call it once?

The software development lifecycle will soon become second nature to you, but while you are still learning I will spell out the steps.

  1. Assign yourself to the issue (on the right under Assignees)
  2. Attach this issue to the GitHub project (on the right under Projects)
  3. Move the issue to the backlog, then in progress on the project board
  4. Create a new git branch off of main
  5. Checkout the git branch
  6. Push/Publish the git branch
  7. Attach that branch to this GitHub issue (on the right under Development)
  8. Start working on it, committing and pushing regularly.
  9. When you are ready for me to review it, push your changes, then create a Pull Request on GitHub.
  10. Link your pull request to this issue under Development if it does not automatically do so.
  11. Move the issue to pending review on the project board
  12. Request me as a reviewer on the pull request.
  13. I will either A. Accept the changes, meaning that you can merge into main and move this issue to completed B. Reject the changes, and give feedback for things to be fixed (this happens a lot to even the best programmers, my changes are usually rejected 2-3 times before they are accepted at my job) meaning that you move this issue back to "In Progress" and go back to step 9

Good luck! As always, ask questions early and often.

mishrayush15 commented 4 days ago

I can implement and fix your issue by creating a Component for the footer exact similar to the way you asked, having your "Created by Aedan Simons-Rudolph and Alex Gerac" text on the left side and having a Github Logo on the right side of the footer that would take the user to this repository every time the user click the Gituhub Logo. You can the use this Component anywhere you want by just importing the component on each page. All you will need to do is to place this component under a div that has CSS properties to place the footer on the end of the webpage (I will also be providing the code for that too). This will fix the issue to write code to make navbar on each page resulting in making the code more readable.

Pandekte commented 4 days ago

Hi, I don't see option to assign myself. I can see: "Assignees No one assigned" and nothing else.

See screenshot included. 2024-10-04_02h31_07

What I can do to complete step 1?

Kindest regards, Pandekte

OrangeAed commented 4 days ago

Hi @mishrayush15 and @Pandekte, I am glad you are interested in the project. I don't want to sound rude but do we know each other? I don't recognize either of your names.

Are you just someone who saw my project and is interested in getting involved?

If you do plan on working with me on the project, can I get contact information like an email address or a Discord?

I believe that I need to add you as collaborators on the GitHub repo if you want to contribute

mishrayush15 commented 3 days ago

Hi @OrangeAed nice to meet you buddy ! I am Ayush from India and buddy I really like the idea and the planning behind your project and that's the reason I thought of helping you out and contributing to your project. I would be extremely happy if you let me contribute to your awesome project mate. By the way, as you said about providing my email, my email is ( ayushmishra780720@gmail.com ). Feel free to contact me anytime buddy. Have a beautiful day 😊

Pandekte commented 1 day ago

Hi There @OrangeAed , I found your github on some page referencing multiple projects that might need a little help. If you are okay with that I would like to contribute. I would love to get more experience with react typescript projects :)

Have a great day, Kindest regards, Pandekte

OrangeAed commented 1 day ago

Thanks for the reply @Pandekte. I am happy that you want to contribute! Can you send me the page you found this on? I never put my project on there which is a little strange.

I have added you as a collaborator so you should be able to assign yourself. Let me know if you have any questions.