OrangeDrangon / android-messages-desktop

Android Messages as a Cross-platform Desktop App
Other
312 stars 27 forks source link

App won't load #356

Closed shareefalis closed 2 years ago

shareefalis commented 2 years ago

Describe the bug open app, Electron is loaded, menu bar is loaded,but actual electron webview window is not loading thus can't use it

Desktop (please complete the following information):

OrangeDrangon commented 2 years ago

Is this consistent across launches or only immediately after install/update?

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Shareef Ali @.> Sent: Tuesday, December 28, 2021 6:09:37 PM To: OrangeDrangon/android-messages-desktop @.> Cc: Subscribed @.***> Subject: [OrangeDrangon/android-messages-desktop] App won't load (Issue #356)

Describe the bug open app, Electron is loaded, menu bar is loaded,but actual electron webview window is not loading thus can't use it

Desktop (please complete the following information):

— Reply to this email directly, view it on GitHubhttps://github.com/OrangeDrangon/android-messages-desktop/issues/356, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGB2A7NFAMK6KHRTAGMAYXTUTI7TDANCNFSM5K45K36Q. You are receiving this because you are subscribed to this thread.Message ID: @.***>

shareefalis commented 2 years ago

Every time it launches.

shareefalis commented 2 years ago

I ran a build and debugged it, it is missing this function on mac. Dock event handler for activation is missing..

if (IS_MAC) {
  app.on("activate", () => {
  if (mainWindow) {
      mainWindow.show();
    }
  });
}

hope this helps!

OrangeDrangon commented 2 years ago

Thanks for debugging it I will get this fixed ASAP.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Shareef Ali @.> Sent: Tuesday, December 28, 2021 8:48:52 PM To: OrangeDrangon/android-messages-desktop @.> Cc: Kyle Rosenberg @.>; Comment @.> Subject: Re: [OrangeDrangon/android-messages-desktop] App won't load (Issue #356)

I ran a build and debugged it, it is missing this function on mac. Dock event handler for activation is missing..

app.on("activate", () => { if (mainWindow) { mainWindow.show(); } }); }```

— Reply to this email directly, view it on GitHubhttps://github.com/OrangeDrangon/android-messages-desktop/issues/356#issuecomment-1002356683, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGB2A7P4WGVTHXXSPJ4FKKLUTJSIJANCNFSM5K45K36Q. You are receiving this because you commented.Message ID: @.***>

OrangeDrangon commented 2 years ago

@shareefalis in a few mins there should be a build on the pull request github action for you to give a go. let me know how if it works.

shareefalis commented 2 years ago

I have a better patch set which add macOS dock badge support and adds the activate function.. clearing the badge depends on the activate function.. doing a pull request