search

OrangeDrangon / android-messages-desktop

Android Messages as a Cross-platform Desktop App
Other
312 stars 27 forks source link

Windows 10+ x64: Native notifications that have been cleared come back when a new notification arrives #362

Open jdrch opened 2 years ago

jdrch commented 2 years ago

Describe the bug On Windows 10+ (read: 10 & 11) x64, native notifications that have been cleared return when a new notification is received in the same session

To Reproduce Steps to reproduce the behavior:

  1. Run Android Message for Desktop on Windows 10 x64
  2. Receive a message, which triggers a native Windows notification
  3. Clear the notification
  4. Receive a subsequent message that triggers another native Windows notification

Expected behavior Only the new notification generated in 4) above should whos

Screenshots N/A

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

jdrch commented 2 years ago

UPDATE

Signal Desktop seems to have this issue too, so it may be a problem that lives upstream in Electron(?) Any ideas?

OrangeDrangon commented 2 years ago

This is probably related to the other windows notification problems we are having. I honestly have no idea what is wrong and it may very well be electrons fault.

jdrch commented 2 years ago

This is probably related to the other windows notification problems we are having. I honestly have no idea what is wrong and it may very well be electrons fault.

I definitely think it's an Electron problem. Does anyone know where the Electron repo/issue reporting forum is?

OrangeDrangon commented 2 years ago

Electron has a GitHub page.

OrangeDrangon commented 2 years ago

Is this resolved with our latest fix for notifications.

jdrch commented 2 years ago

It's not completely fixed for me but it's gotten better, with fewer previously dismissed notifications surfacing. I think part of the problem is on the Windows side of things too, but I'm not sure.

OrangeDrangon commented 2 years ago

I will try to get back to updating dependencies. Maybe a newer electron version fixes it :shrug:

OrangeDrangon commented 1 year ago

Has the new update helped at all?

jdrch commented 1 year ago

I'll look into it on my Windows 11 laptop. At the last update I was having the same issue with native Windows apps but it seems lately mostly Android Messages and WhatsApp are affected. Thanks for the continued effort on this!