search

OrangeDrangon / android-messages-desktop

Android Messages as a Cross-platform Desktop App
Other
312 stars 27 forks source link

Binding Cmd + W to close window button. #377

Open fermata opened 2 years ago

fermata commented 2 years ago

Is your feature request related to a problem? Please describe. I cannot close the window with Cmd + W shortcut like the other apps do.

Describe the solution you'd like Maybe closing a window?

Thanks for the great app by the way.

OrangeDrangon commented 2 years ago

I do not have a mac to test but CTRL+W works on linux. I assume there is a platform related issue going on.

innesst commented 2 years ago

CTRL+W closes on windows 10

OrangeDrangon commented 2 years ago

https://github.com/OrangeDrangon/android-messages-desktop/blob/ff20c5141fc111730580046682860374d6f14f2f/src/menu/windowMenu.ts#L3

This is the code for the window menu. It is just relying on an electron provided menu template.

anonymousaga commented 2 years ago

+1

OrangeDrangon commented 1 year ago

according to some research cmd+q is the global window close on macos. closing wont fix

anonymousaga commented 1 year ago

I disagree with this. Cmd+q is quit. Cmd+w is to close all windows. This app can run without any windows (notifications), so it makes sense to have cmd+w & cmd+q.

OrangeDrangon commented 1 year ago

fair enough this can stay open but the change will need to come from someone else.

mananong commented 3 months ago

+1 on this feature please, amazing app nonetheless thank you!!