OrangeDrangon / android-messages-desktop

Android Messages as a Cross-platform Desktop App
Other
331 stars 28 forks source link

Site Does not Load on Latest Electron #426

Open OrangeDrangon opened 1 year ago

OrangeDrangon commented 1 year ago

When opening the application with an updated electron (26). It hangs on a white screen. With these errors in console.

image

OrangeDrangon commented 1 year ago

The most modern version it does load in is 21.

OrangeDrangon commented 1 year ago

Something changed in electron 22 such that it now enforces something so that the error "This document requires 'TrustedScript' assignment." prevents our preload from running.

george-dy commented 1 year ago

I've never built anything with Electron, but it looks like it might have something to do with CSP? I just wanted to add some links I found while searching, though I don't know if any of them are actually useful.

https://csplite.com/csp219/ https://stackoverflow.com/a/74201095 https://stackoverflow.com/questions/62081028/this-document-requires-trustedscripturl-assignment

LanikSJ commented 11 months ago

I've gotten the latest Electron to play nice using the TypeScript files from this commit: https://github.com/ElementalWarrior/android-messages-desktop/commit/e7f2e0215318a5dc4e79a881330a1886cf06eac5#diff-11db236acd6b02b1229e7d325e9bf8edb521032e6388f68b6a884ec24bbe291f

I don't pretend to have a clue about TypeScript you can see my change here: https://github.com/LanikSJ/android-messages-desktop/pull/328

You can test my fork if you like. I'm using the app right now and it works great, builds etc.